New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pasting link sometimes doesn't convert it to MD link #107

Closed
borekb opened this Issue Feb 3, 2016 · 4 comments

Comments

Projects
None yet
2 participants
@borekb

borekb commented Feb 3, 2016

I like the feature of MDE where you just select text and press Ctrl+V to turn it into a Markdown link. However, this doesn't work for me in some cases:

mde-paste-link

I was not able to track down when and why this happens, I will try to observe it to find out more about it.

@mike-ward mike-ward added the bug label Feb 3, 2016

@mike-ward

This comment has been minimized.

Show comment
Hide comment
@mike-ward

mike-ward Feb 3, 2016

Owner

Probably a bug in the pattern matching. Nice gif. Illustrates the problem clearly. 👍

Owner

mike-ward commented Feb 3, 2016

Probably a bug in the pattern matching. Nice gif. Illustrates the problem clearly. 👍

@mike-ward

This comment has been minimized.

Show comment
Hide comment
@mike-ward

mike-ward Feb 12, 2016

Owner

This occurs in HTML blocks which, is by design. In HTML blocks, Markdonw doesn't make sense.

Owner

mike-ward commented Feb 12, 2016

This occurs in HTML blocks which, is by design. In HTML blocks, Markdonw doesn't make sense.

@mike-ward mike-ward closed this Feb 12, 2016

@borekb

This comment has been minimized.

Show comment
Hide comment
@borekb

borekb Feb 15, 2016

It does also happen outside of HTML contexts. The simplest reproducable case is this:

<img src="" />

Link

Some other text

If you paste over the "Link" text (which is a new paragraph) it doesn't work.

Interesting is that if you remove the "Some other text" part, it starts working again. I don't get why it would do that but it might be some clue..

borekb commented Feb 15, 2016

It does also happen outside of HTML contexts. The simplest reproducable case is this:

<img src="" />

Link

Some other text

If you paste over the "Link" text (which is a new paragraph) it doesn't work.

Interesting is that if you remove the "Some other text" part, it starts working again. I don't get why it would do that but it might be some clue..

@mike-ward

This comment has been minimized.

Show comment
Hide comment
@mike-ward

mike-ward Feb 15, 2016

Owner

Looks like when it's also in proximity of an HTML block (within one line) it fails. Probably one of those famous off-by-one errors. I'll look into it further.

Owner

mike-ward commented Feb 15, 2016

Looks like when it's also in proximity of an HTML block (within one line) it fails. Probably one of those famous off-by-one errors. I'll look into it further.

@mike-ward mike-ward reopened this Feb 15, 2016

mike-ward added a commit that referenced this issue Feb 15, 2016

@mike-ward mike-ward closed this Feb 20, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment