Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upPrevent "disconnection" when output window content is saved to file #103
Conversation
This comment has been minimized.
This comment has been minimized.
|
Scheduled for v2.7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Dmitry-Me commentedDec 6, 2019
This works around #68
Here's what happens. When Ctrl-S is used to save the output
ITextBuffer.OnContentTypeChangedis fired and it's clear that content type is changed from "output" to "plaintext" and it's never changed back afterwards. Once this happens Visual Studio builds a new list of classifier objects which are willing to work with the sameITextBufferobject now having new content type.The original code has
ContentTypeset to "output" only so this plugin is ignored. The new code also allows to consider this plugin for "plaintext" content type. This works but it will also consider this plugin for text files in the solution. So this change tags previously knownITextBufferobjects which once were of "output" type so that it can recognize them later no matter how their content type changed.