Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent "disconnection" when output window content is saved to file #103

Merged
merged 1 commit into from Dec 6, 2019

Conversation

@Dmitry-Me
Copy link
Contributor

Dmitry-Me commented Dec 6, 2019

This works around #68

Here's what happens. When Ctrl-S is used to save the output ITextBuffer.OnContentTypeChanged is fired and it's clear that content type is changed from "output" to "plaintext" and it's never changed back afterwards. Once this happens Visual Studio builds a new list of classifier objects which are willing to work with the same ITextBuffer object now having new content type.

The original code has ContentType set to "output" only so this plugin is ignored. The new code also allows to consider this plugin for "plaintext" content type. This works but it will also consider this plugin for text files in the solution. So this change tags previously known ITextBuffer objects which once were of "output" type so that it can recognize them later no matter how their content type changed.

@mike-ward mike-ward merged commit f66204a into mike-ward:master Dec 6, 2019
1 check passed
1 check passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@Dmitry-Me Dmitry-Me deleted the Dmitry-Me:preventDisconnection branch Dec 6, 2019
@mike-ward

This comment has been minimized.

Copy link
Owner

mike-ward commented Dec 6, 2019

Scheduled for v2.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.