Implement leftmost insert #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
jchris
commented
Mar 14, 2023
src/base.js
Outdated
|
|
||
| // then delete | ||
| throw new Error('Not Implemented :(') | ||
| } |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
jchris
commented
Mar 19, 2023
src/base.js
Outdated
| encodeNode () { | ||
| const list = this.entryList.entries.map((entry) => entry.encodeNode()) | ||
| async encodeNode () { | ||
| const list = await Promise.all(this.entryList.entries.map(async (entry) => await entry.encodeNode())) |
There was a problem hiding this comment.
I checked and applying this change to main makes no difference to test passing
Merged
|
fixed in #18 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this one is probably worth you review. it's still AI assisted but at I did a better job directing it