Is this still being maintained? #2

Closed
jimisaacs opened this Issue Sep 23, 2011 · 7 comments

Projects

None yet

3 participants

@jimisaacs

There's a couple issues I noticed.
The required node version doesn't exist as a tag anymore.
It requires two dependencies not listed in the package.json, but exist in this repo.
The sys module is used when it has been renamed to util, and this module isn't even used anyway.
It throws an error when usage is wrong, is this necessary? My first thought was something else was wrong with my platform.

Basically, this module is interesting to me, and most likely others, because there's a few threads that end up pointing to here because there's no many bugs with the built-in couch db replicator.

Thank you, This thing was a life saver when setting up an npm registry clone.

I'm not quite sure how it works yet, because when I run it and it exits the process saying "replication complete", sometimes I still see that it leaves the couch processes of main.js running, and I'm wondering if this is a bug.

@mikeal
Owner
mikeal commented Sep 23, 2011

its still maintained, I've just been a little lazy about updating the deps, I'll get to it this week.

On Sep 23, 2011, at 2:23, Jim Isaacsreply@reply.github.com wrote:

There's a couple issues I noticed.
The required node version doesn't exist as a tag anymore.
It requires two dependencies not listed in the package.json, but exist in this repo.
The sys module is used when it has been renamed to util, and this module isn't even used anyway.
It throws an error when usage is wrong, is this necessary? My first thought was something else was wrong with my platform.

Basically, this module is interesting to me, and most likely others, because there's a few threads that end up pointing to here because there's no many bugs with the built-in couch db replicator.

Thank you, This thing was a life saver when setting up an npm registry clone.

I'm not quite sure how it works yet, because when I run it, and it closes the process saying "replication complete", I still see that it sometimes leaves the couch processes running, and I'm wondering if this is a bug.

Reply to this email directly or view it on GitHub:
#2

@mmalecki
Contributor

@mikeal I've fixed dependencies and removed sys usage in my fixes branch. It should be installable from npm now. Diff is here. Feel free to merge it.

@jimisaacs

Thanks guys!

@mikeal
Owner
mikeal commented Sep 27, 2011

can we convert this in to a pull request to make the code review easier?

@mikeal
Owner
mikeal commented Sep 27, 2011

i wrote all this code in the last few months, why the hell was I requiring sys! i should have my head examined. thanks btw :)

@mmalecki
Contributor

@mikeal Sure, there you go: #3 :).

@mikeal
Owner
mikeal commented Sep 27, 2011

merged.

@mikeal mikeal closed this Sep 27, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment