Skip to content
This repository

http.createClient is deprecated #382

Closed
thesmart opened this Issue · 4 comments

3 participants

John Smart Mikeal Rogers Isaac Z. Schlueter
John Smart

With v1.2.0, I'm getting:

http.createClient is deprecated. Use `http.request` instead.

John Smart

Ah, for some reason default npm is installing v1.2.0? Changed my package.json to explicitly request v2.12.0

Mikeal Rogers
Owner

wow, why is npm installing a version so old? @isaacs

Isaac Z. Schlueter
Collaborator

@mikeal Without seeing the log output, and knowing what version of npm and node @thesmart is using, or what his package.json says, I have no way of knowing.

John Smart

Hmm, the issue no longer repros. Now when I install without a version number, I get the right one.

I pulled from my console logs this output:

Smarts-MacBook-Pro:node-MessageBus smart$ rm -rf node_modules
Smarts-MacBook-Pro:node-MessageBus smart$ npm install request
npm http GET https://registry.npmjs.org/request/1.2.0
npm http 200 https://registry.npmjs.org/request/1.2.0
npm http GET https://registry.npmjs.org/request/-/request-1.2.0.tgz
npm http 200 https://registry.npmjs.org/request/-/request-1.2.0.tgz
request@1.2.0 node_modules/request

Now when I run, I get the latest:

Smarts-MacBook-Pro:node-MessageBus smart$ npm install request
npm http GET https://registry.npmjs.org/request
npm http 200 https://registry.npmjs.org/request
request@2.12.0 node_modules/request

Maybe my package.json was screwed up? Sorry fellas. :8ball:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.