Mike Cafarella mikecafarella

  • Joined on

Organizations

Cloudera EECS485
mikecafarella opened pull request netj/librarian#1
Mike Cafarella
Cafarella dev
4 commits with 233 additions and 532 deletions
Mike Cafarella
Merge develop into master to retrigger green build
mikecafarella commented on pull request HazyResearch/deepdive#233
Mike Cafarella

@adamwgoldberg It's worthwhile to have a new master pull on the merits. Don't need to do it just for the flag.

mikecafarella commented on pull request HazyResearch/deepdive#209
Mike Cafarella

@zifeishan It looks like a lot has changed here, and that you are planning to make further changes. I will do a full review when your new changes a…

Mike Cafarella
Mike Cafarella
Updated volume mounting instructions
13 commits with 24 additions and 38 deletions
mikecafarella commented on pull request HazyResearch/deepdive#235
Mike Cafarella

Feiran, I went over the PR. Everything looks good except that File.createTmpFile() call. Can you address this?

mikecafarella commented on pull request HazyResearch/deepdive#235
Mike Cafarella

This temp file could be huge. But File.createTempFile() will put something in /tmp, which is often on a small volume. This code is thus extremely p…

mikecafarella commented on pull request HazyResearch/deepdive#209
Mike Cafarella

So the loss of 'funcName' isn't crucial? I am not sure where funcName comes from, so I can't tell if its loss will possibly cause a name clash here.

mikecafarella commented on pull request HazyResearch/deepdive#209
Mike Cafarella

Zifei, I'm not sure what's happening on this line. Can you weigh in?

Mike Cafarella
  • Mike Cafarella 01d995b
    Merge pull request #232 from HazyResearch/adam-docker
  • Adam Goldberg 5edcd57
    Suppress DB output during DeepDive initialization from Dockerfile
  • 7 more commits »
Mike Cafarella
Suppress GP output and clarify Docker setup messages
8 commits with 6 additions and 7 deletions
Mike Cafarella
Mike Cafarella
Grounding refactoring
47 commits with 639 additions and 6,376 deletions
Mike Cafarella

Feiran, the right way to do this is new File(grandparentDir, new File(parentDir, filename)).getCanonicalPath(). However, it's not worth holding up …

Mike Cafarella
Mike Cafarella
Propogate greenplum removals to master
3 commits with 13 additions and 11 deletions
mikecafarella commented on pull request HazyResearch/deepdive#230
Mike Cafarella

Again, use File here.

mikecafarella commented on pull request HazyResearch/deepdive#230
Mike Cafarella

DROP TABLE is such a toxic operation that we should consider making it a method that one has to call in order to generate the SQL. Inside that meth…

mikecafarella commented on pull request HazyResearch/deepdive#230
Mike Cafarella

If this clause is executed, does that mean that you will copy the last weights, and then immediately drop the destination table? Not clear what the…

mikecafarella commented on pull request HazyResearch/deepdive#230
Mike Cafarella

Use Java File object to build paths like this, not manual "/" chars and hard-coded strings. File will take care of directory separators and control…

mikecafarella commented on pull request HazyResearch/deepdive#230
Mike Cafarella

This is what I'm talking about, regarding BooleanType reserved word. See the "2" comment elsewhere

mikecafarella commented on pull request HazyResearch/deepdive#230
Mike Cafarella

Can we use a reserved word for the BooleanType constant here? In another part of the code, the magic number is "0" instead of "2" and it is not cle…

mikecafarella commented on pull request HazyResearch/deepdive#230
Mike Cafarella

We might want to promulgate a new coding standard: no direct SQL queries without a function wrapper, into which parameters are passed. The goal in …

mikecafarella commented on pull request HazyResearch/deepdive#230
Mike Cafarella

I am not entirely sure what an observation query is, so I don't know if failing to run it is catastrophic or not. Is this for debugging, or for ind…

mikecafarella commented on pull request HazyResearch/deepdive#230
Mike Cafarella

How is calling "getFileNameFromPath(p)" better than "new File(p).getName()"? Just to be all Scala-like?

mikecafarella commented on pull request HazyResearch/deepdive#230
Mike Cafarella

Why remove the ordering? Was this an unnecessary element of the query?

mikecafarella commented on pull request HazyResearch/deepdive#230
Mike Cafarella

This kind of construction makes me extremely nervous. It's basically a huge amount of code that's entirely opaque to the build system; what if ther…

mikecafarella commented on pull request HazyResearch/deepdive#230
Mike Cafarella

I fully support removing methods that are prefixed with WRONG.