Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to use Fetch (with keepalive) instead of Beacon #1160

Closed
rohandebsarkar opened this issue May 20, 2022 · 3 comments
Closed

Request to use Fetch (with keepalive) instead of Beacon #1160

rohandebsarkar opened this issue May 20, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@rohandebsarkar
Copy link
Contributor

Recently, I found out that beacon request are blocked by ad blockers such as uBlock Origin. After searching a bit on the internet, I found that the beacon request are equivalent to fetch API with keepalive option.

Therefore, I tried replacing beacon with fetch (with keepalive option), it seems to work fine.

So I think, if both methods are equivalent it would be better to use fetch as it will not be blocked by ad blockers, or may be to add a fallback to fetch if the beacon fails.

Anyway, thanks for this awesome project.

@MagicLike
Copy link
Contributor

I just also discovered that.
Even if it is unnessesary, here a screenshot from the uBlock log, when I triggered some events:
grafik

@rohandebsarkar
Copy link
Contributor Author

I created PR #1163 to solve this.

@rohandebsarkar
Copy link
Contributor Author

This feature was released with v1.32.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants