Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If a Phabricator review request is still pending, but another reviewer has Approved, the review isn't included in the total #2

Closed
mikeconley opened this issue Sep 11, 2018 · 2 comments

Comments

@mikeconley
Copy link
Owner

@mikeconley mikeconley commented Sep 11, 2018

There's a limitation in the Differential revision query API where review requests are not listed in the following scenario:

  1. The user is one of several reviewers on a revision
  2. The user is a non-blocking reviewer
  3. Another user has given an approval such that the revision gets the Approved status

This is something that mcote's team has been banging against too.

It might be simpler to get an accurate total of Phabricator reviews by just scraping the dashboard.

@mikeconley
Copy link
Owner Author

@mikeconley mikeconley commented Sep 14, 2018

Another thing that can occur is that if a user is one of several blocking reviewers, even if that user has completed a review on the latest revision, the review request will still be set at the "needs-review" state, so it'll keep showing up in the query.

@mikeconley
Copy link
Owner Author

@mikeconley mikeconley commented Oct 6, 2018

This should be fixed in 0.2, which uses page scraping instead of the Conduit API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant