If a Phabricator review request is still pending, but another reviewer has Approved, the review isn't included in the total #2
Comments
|
Another thing that can occur is that if a user is one of several blocking reviewers, even if that user has completed a review on the latest revision, the review request will still be set at the "needs-review" state, so it'll keep showing up in the query. |
|
This should be fixed in 0.2, which uses page scraping instead of the Conduit API. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There's a limitation in the Differential revision query API where review requests are not listed in the following scenario:
This is something that mcote's team has been banging against too.
It might be simpler to get an accurate total of Phabricator reviews by just scraping the dashboard.
The text was updated successfully, but these errors were encountered: