OS X client breaks on apostrophe #52

Open
zannalov opened this Issue Sep 4, 2012 · 2 comments

3 participants

@zannalov

I've found that if the host machine has a directory with an apostrophe, the OS X client will only show the name up to (but not including) the apostrophe in the mounted filesystem. This means when you try to enter the directory, OS X requests the truncated name (which doesn't exist on the server) and gets an access error. For example, a directory named "I'm sure this will work" shows up on the Mac as "I". Apparently apostrophes are not encoded by encodeURI, and OS X needs them to be encoded.

@zannalov zannalov added a commit to zannalov/jsDAV that referenced this issue Sep 4, 2012
@zannalov zannalov Apostrophes break OS X client, apparently. This fixes #52 by explicit…
…ly encoding apostrophes as well.
60e4d2f
@zannalov zannalov added a commit to zannalov/jsDAV that referenced this issue Sep 6, 2012
@zannalov zannalov Upon further testing, found that ampersands and several other charact…
…ers break the OS X client as well. Changed my approach to completely escape all path fragments, and this seems to be working for every file I throw at it. Fixes #52
091a6f8
@zannalov zannalov added a commit to zannalov/jsDAV that referenced this issue Sep 6, 2012
@zannalov zannalov I spoke too soon. Previous commit reintroduced the problem with quote…
… marks while fixing most other characters. Forgot to go back and test the original problem. This has been tested with quote marks, double quote marks, ampersands, dashes, spaces, etc. Fixes #52
9b0f694
@thieso2

any explanation why this is not merged yet? Is the fix invalid or just missing some tests?

@tiff

I can reproduce this with OSX Mountain Lion and latest master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment