Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Change config file priority #26
@jordonbaade Can you please provide a little bit more information about this issue. I hear what you are saying (about moving config file up on priority chain). but I am still unclear exactly what the exact issue is. I have to think about applying this to the core modules I use for all gulp-xxxx plugins (ie phpspec, behat, and codeception).
While it appears to be an isolated issue with regards to PHPUnit, I still want to know what is happening as gulp.src is basically an entrypoint into the plugin, but the actual code does not use the src files?
I'm new, so I'll try.
Basically the core issue I see is that this if statement:
Is impossible to enter because of this if statement:
Correct me if I'm wrong, but gulp.src() should always have an argument of files passed to it, otherwise it throws a fit. This means that a configurationFile if statement as second priority can never be entered as it stands.
Elixir is passing a string pattern for the test files from:
It would seem this Elixir file was written prior to this commit which introduced pulling from gulp.src:
Jeffrey could probably change it so that there is a separate option in phpunit.js for the watch pattern, and update the gulp.src() to work with that last commit, but in the interest of keeping everything simple & flexible, and seeing that gulp-phpunit didn't seem (to me) to allow use of a configuration file through it's own option.configurationFile I thought this was a good route.
I also considered doing a extension check to see if it was an xml file, and if not go to a new priority that doesn't use -c (because when using -c phpunit is looking for the xml file, not the php test files.) but still pulls from gulp.src()
Happy to go any route, was bored and thought I'd try to contribute :)
Elixir needs updated after a commit to gulp-phpunit, but gulp-phpunit option.configurationFile doesn't seem to work at all either.