Small refactor of the URL replacement code #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… code conventions. Updated bad ajax test that defined requests without a URL
scottgonzalez
added a commit
that referenced
this pull request
May 30, 2011
Small refactor of the URL replacement code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran some speed tests on the method currently used by Amplify to replace URL parameters with passed in data. I found using a regular expression replace with a callback was faster than redefining RegExp's for each item in a data structure.
You can see my perf tests here: http://jsperf.com/quick-templates-compared/2
These two commits handle the change to the faster method.