Skip to content
Browse files

Fixing up TODO and docs

  • Loading branch information...
1 parent af3b95d commit a33892c7371def355d80ecfbef253cf8213bbeb3 @mikel committed
Showing with 3 additions and 13 deletions.
  1. +2 −12 TODO.rdoc
  2. +1 −1 lib/mail/network/delivery_methods/smtp.rb
View
14 TODO.rdoc
@@ -1,17 +1,7 @@
== Not really in any order:
-* Make body, part, field, header, message all responding correctly to :encoded
- and :decoded messages. And remove ":to_s" as a method on these
- classes. Encoded needs to return the field, encoded, ready to send in the
- mail system, that is, US-ASCII. Decoded needs to return the field decoded ready to
- view. :to_s is (unfortunately) ambiguous in this case. Maybe return a warning
- with :to_s and say "please use encoded or decoded instead" or :to_s returns
- "Showing you the encoded view by default, call :decoded to see the decoded view"
-
-* Refactor out the multibyte and string handling. Make ActiveSupport a dependancy
-
-* Clean up the relationship between message, parts and bodies. Need to make sure
- once parsed, that a body knows what encoding it is, for example.
+* Add multibyte handling to fields, if they get a multibyte string, try encoding it into
+ UTF-8 B first, if this fails, throw an error.
* Cleanup the treetop parsers......... do I _really_ need that many entrance files?
View
2 lib/mail/network/delivery_methods/smtp.rb
@@ -27,7 +27,7 @@ module Mail
# Mail.defaults do
# delivery_method :smtp, { :address => "smtp.gmail.com",
# :port => 587,
- # :domain => 'baci.lindsaar.net',
+ # :domain => 'your.host.name',
# :user_name => '<username>',
# :password => '<password>',
# :authentication => 'plain',

0 comments on commit a33892c

Please sign in to comment.
Something went wrong with that request. Please try again.