Browse files

Add advice for iterating on pull requests

Many contributors do not know that they can push or (rebase and) force push changes to their PR branch.

This is really useful for keeping PR's clean after there's been a bit of discussion.
  • Loading branch information...
1 parent f09cc94 commit ed9edf5a8db32537a90ff77317e377a8b5916225 @bf4 bf4 committed Jun 3, 2014
Showing with 2 additions and 1 deletion.
  1. +2 −1
@@ -16,7 +16,8 @@ pull request merged quickly:
7. Update the README if needed to reflect your change / addition
8. Update the CHANGELOG and give yourself credit
9. With all specs passing push your changes back to your fork
-10. Send me a pull request
+10. Send me a pull request.
+ - If it needs any changes, please push or force push to the same branch you made the pull request from. GitHub will just update the pull request with your changes.
Note, specs that break MRI 1.8.7 or 1.9.3 will not be accepted.

0 comments on commit ed9edf5

Please sign in to comment.