Duplicate block call in configuration.rb #15

Closed
salesking opened this Issue Dec 11, 2009 · 1 comment

Comments

Projects
None yet
2 participants
@ghost

ghost commented Dec 11, 2009

mail/configuration.rb line 98 following, change from:

def set_settings(klass, host_array = nil, &block)
  if host_array
    klass.instance.settings do
      host host_array[0]
      port host_array[1]
    end
  end
  if block_given?
    klass.instance.settings(&block)
  end
  klass.instance.settings(&block)
end

To:
def set_settings(klass, host_array = nil, &block)
if host_array
klass.instance.settings do
host host_array[0]
port host_array[1]
end
end
klass.instance.settings(&block) if block_given?
end

Owner

mikel commented Dec 13, 2009

Thanks, resolved in eecc12a..0ae2bc8. Need to call the block if given or not.

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment