Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsing of binary encoded message parts are mangled by call to .to_crlf #871

Closed
jeremyricharddavies opened this issue Apr 15, 2015 · 1 comment

Comments

@jeremyricharddavies
Copy link

Hi

When parsing an incoming multi-part message, the loading process assigns the raw_source property (line 1990 of message.rb), but it then calls .to_crlf on this which mangles the byte sequences of binary encoded attachments (eg: images).

Is there a reason that .to_crlf is used here? I have removed this call from my local gem source and re-tested with success (on the specific messages that I am working with) but perhaps there are other messages that require this for decoding purposes.

Thanks

@jeremy
Copy link
Collaborator

jeremy commented Sep 30, 2015

What Content-Transfer-Encoding are your incoming MIME parts? If they're 8bit they'll be encoded as CRLF-separated octets, for example.

@jeremy jeremy closed this as completed Sep 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants