Added to_yaml & from_yaml (as well as to_hash & from_hash)#201
Closed
srushti wants to merge 1 commit into
Closed
Conversation
Owner
|
Awesome, thanks for your work, however, the specs fail on the latest master. There was an error in the spec regexp which I fixed. |
Owner
|
I have merged this in. |
|
Is this [pull request] compatible with YAML::dump? Unless I'm missing something it seems not. Also, the current serialization isn't a full representation of the Message object. Many instance variables aren't included, e.g. delivery_handler. |
|
This is the implementation used in Object: |
urbanautomaton
pushed a commit
to urbanautomaton/mail
that referenced
this pull request
May 17, 2011
urbanautomaton
pushed a commit
to urbanautomaton/mail
that referenced
this pull request
May 17, 2011
Contributor
|
To address some of the issues raised by sandstrom (as I ran into precisely the same problem with the missing fields), I've made a couple of changes and submitted pull request #237 - details can be found there. (I haven't addressed the YAML::dump issue though) Edit: now I have. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mail::Message#to_yaml used to give an error earlier.
TypeError: can't dump anonymous class Class