should support blank or empty display names #394

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
@yyyc514
Contributor

yyyc514 commented May 11, 2012

I tried playing around with quoted_string, content, and quoted_pair but couldn't figure it out. Treetop is greek to me. Here is a failing spec.

@mikel

This comment has been minimized.

Show comment Hide comment
@mikel

mikel Nov 17, 2012

Owner

Yeah, going to hold off on this one for now. See if it still fails when I finish merging the other pull requests.

Owner

mikel commented Nov 17, 2012

Yeah, going to hold off on this one for now. See if it still fails when I finish merging the other pull requests.

@jeremy

This comment has been minimized.

Show comment Hide comment
@jeremy

jeremy Jan 19, 2013

Collaborator

@yyyc514 could you check whether this is still an issue?

Collaborator

jeremy commented Jan 19, 2013

@yyyc514 could you check whether this is still an issue?

@yyyc514

This comment has been minimized.

Show comment Hide comment
@yyyc514

yyyc514 Jan 19, 2013

Contributor

I can look into next week... why not merge the spec and then insure the tests pass?

Contributor

yyyc514 commented Jan 19, 2013

I can look into next week... why not merge the spec and then insure the tests pass?

@jeremy

This comment has been minimized.

Show comment Hide comment
@jeremy

jeremy Jan 20, 2013

Collaborator

Because distributing work is an effective way to combat the enormous issue backlog :)

Collaborator

jeremy commented Jan 20, 2013

Because distributing work is an effective way to combat the enormous issue backlog :)

@jeremy

This comment has been minimized.

Show comment Hide comment
@jeremy

jeremy Jan 27, 2013

Collaborator

@yyyc514 twist my arm, will ya! It works now 😁

>> Mail.new(%(From: Mikel Lindsaar <test@lindsaar.net>, " " <jack@lindsar.com>, "" <bob@gmail.com>\r\n\r\n)).from
=> ["test@lindsaar.net", "jack@lindsar.com", "bob@gmail.com"]
>> Mail.new(%(From: Mikel Lindsaar <test@lindsaar.net>, " " <jack@lindsar.com>, "" <bob@gmail.com>\r\n\r\n))[:from].display_names
=> ["Mikel Lindsaar", nil, nil]
Collaborator

jeremy commented Jan 27, 2013

@yyyc514 twist my arm, will ya! It works now 😁

>> Mail.new(%(From: Mikel Lindsaar <test@lindsaar.net>, " " <jack@lindsar.com>, "" <bob@gmail.com>\r\n\r\n)).from
=> ["test@lindsaar.net", "jack@lindsar.com", "bob@gmail.com"]
>> Mail.new(%(From: Mikel Lindsaar <test@lindsaar.net>, " " <jack@lindsar.com>, "" <bob@gmail.com>\r\n\r\n))[:from].display_names
=> ["Mikel Lindsaar", nil, nil]

@jeremy jeremy closed this Jan 27, 2013

@yyyc514

This comment has been minimized.

Show comment Hide comment
@yyyc514

yyyc514 Feb 14, 2013

Contributor

Thanks!

Contributor

yyyc514 commented Feb 14, 2013

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment