Skip to content
This repository

Remove Gemfile.lock from gemspec #425

Merged
merged 1 commit into from over 1 year ago

5 participants

Kamil Baćkowski Arun Agrawal David Kim Ryan Bigg Mikel Lindsaar
Kamil Baćkowski

Removing Gemfile.lock from files list in gemspec since it's no longer in the repository.

This produces errors in bundler :

mail at /home/users/kartapracy/kartapracy24.pl/shared/bundle/ruby/1.9.1/bundler/gems/mail-f19ffd459955 did not have a valid gemspec.
This prevents bundler from installing bins or native extensions, but that may not affect its functionality.
The validation message from Rubygems was:
["Gemfile.lock"] are not files

Arun Agrawal
Collaborator

When you do bundle install it will create a Gemfile.lock file and package that into .gem when bundling.

When you are getting this error ?

Kamil Baćkowski

I get this warning message every time i run bundle from in my application which uses this gem.

However i'm using version from github :

gem 'mail', :require => false, :git => 'http://github.com/mikel/mail.git'

Kamil Baćkowski

It was discussed many times that Gemfile.lock shouldn't be included in gems (http://yehudakatz.com/2010/12/16/clarifying-the-roles-of-the-gemspec-and-gemfile)

David Kim

I have the same issue as my Gemfile points to my forked version of mail on github.

Since Gemfile.lock is not under the version control, I believe it should be removed from the gemspec file as well.

I can just ignore the warning, but it's annoying.

Ryan Bigg

@mikel: This patch looks good to merge.

Mikel Lindsaar
Owner

Thanks, good catch @kbackowski

Mikel Lindsaar mikel merged commit d7dfbe5 into from November 17, 2012
Mikel Lindsaar mikel closed this November 17, 2012
Jordan Harband ljharb referenced this pull request from a commit in ljharb/mail October 02, 2013
Jordan Harband Removing Gemfile.lock from gemspec, see #425 dadff9f
Conrad Irwin ConradIrwin referenced this pull request from a commit October 02, 2013
Jordan Harband Removing Gemfile.lock from gemspec, see #425 [Closes #623]
Using https for rubygems, to remove deprecation warning
0193453
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Showing 1 unique commit by 1 author.

Aug 07, 2012
Kamil Baćkowski Removing Gemfile.lock from gemspec files d7dfbe5
This page is out of date. Refresh to see the latest.

Showing 1 changed file with 1 addition and 1 deletion. Show diff stats Hide diff stats

  1. 2  mail.gemspec
2  mail.gemspec
@@ -22,5 +22,5 @@ Gem::Specification.new do |s|
22 22
   s.add_dependency('tlsmail', '~> 0.0.1') if RUBY_VERSION == '1.8.6'
23 23
 
24 24
   s.require_path = 'lib'
25  
-  s.files = %w(README.md CONTRIBUTING.md CHANGELOG.rdoc Dependencies.txt Gemfile Gemfile.lock Rakefile TODO.rdoc) + Dir.glob("lib/**/*")
  25
+  s.files = %w(README.md CONTRIBUTING.md CHANGELOG.rdoc Dependencies.txt Gemfile Rakefile TODO.rdoc) + Dir.glob("lib/**/*")
26 26
 end
Commit_comment_tip

Tip: You can add notes to lines in a file. Hover to the left of a line to make a note

Something went wrong with that request. Please try again.