Skip to content
This repository

Fix build on Ruby18. We should specify endian for UTF16/32. #471

Merged
merged 1 commit into from about 1 year ago

2 participants

Toshinori Kajihara Jeremy Kemper
Toshinori Kajihara

I found build error the following url.

https://travis-ci.org/mikel/mail/jobs/3381626

I think we should specify endian for UTF16/32.

Jeremy Kemper jeremy merged commit 64f4eb5 into from January 18, 2013
Jeremy Kemper jeremy closed this January 18, 2013
Jeremy Kemper
Collaborator

Green on my machine since big-endian is assumed. Should fix on Travis though.

Jeremy Kemper jeremy referenced this pull request from a commit January 22, 2013
Jeremy Kemper Update CHANGELOG for #471, #475, #489, #495 a0b88dd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Showing 1 unique commit by 1 author.

Nov 30, 2012
Toshinori Kajihara Fix build on Ruby18. We should specify endian for UTF16/32. 819c476
This page is out of date. Refresh to see the latest.

Showing 1 changed file with 4 additions and 0 deletions. Show diff stats Hide diff stats

  1. 4  lib/mail/version_specific/ruby_1_8.rb
4  lib/mail/version_specific/ruby_1_8.rb
@@ -107,6 +107,10 @@ def Ruby18.fix_encoding(encoding)
107 107
       case encoding.upcase
108 108
       when 'UTF8'
109 109
         'UTF-8'
  110
+      when 'UTF16', 'UTF-16'
  111
+        'UTF-16BE'
  112
+      when 'UTF32', 'UTF-32'
  113
+        'UTF-32BE'
110 114
       else
111 115
         encoding
112 116
       end
Commit_comment_tip

Tip: You can add notes to lines in a file. Hover to the left of a line to make a note

Something went wrong with that request. Please try again.