Clarify parser behavior for funky angle bracket addresses #485

Merged
merged 1 commit into from Jan 23, 2013

2 participants

@bpot

This PR doesn't change any behavior. It only makes the code more explicit for addresses of the form blah <blah.co.jp>. Currently Mail::Address#address will return nil for these type of addresses.

It's not 100% clear to me that this is intended behavior. If this is a bug I'm more than happy to make another PR that allows us to recognize these types of addresses instead of ignoring them.

@jeremy jeremy merged commit 278e3b1 into mikel:master Jan 23, 2013
@jeremy
Collaborator

IMO we should parse these addresses, even if spammy. The address parser should try its hardest to make sense of what it's seeing and leave policy decisions up to other mail handlers.

@jeremy
Collaborator

@bpot thanks for the nice series of pull requests, too 😁

@jeremy jeremy added a commit that referenced this pull request Jan 23, 2013
@jeremy jeremy Update CHANGELOG for #482, #485 8fd9272
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment