Remove confusing no-op #499

Merged
merged 1 commit into from Jan 26, 2013

Projects

None yet

2 participants

@ConradIrwin
Collaborator

I just spent about an hour trying to figure out what was going on here. Hopefully this will save someone else some time in future :).

@ConradIrwin ConradIrwin Remove confusing no-op
This line previously always set the (unused) local variable body to nil.

I assume it meant to read `self.body = nil if body.nil?` however
`body.nil?` cannot happen as the previous line would crash.

Closer inspection reveals that the initialize method calls either
init_with_string or init_with_hash, both of which eventually set the
body to non-nil.
eb3f1ab
@jeremy jeremy merged commit 568acbe into mikel:master Jan 26, 2013
@jeremy jeremy added a commit that referenced this pull request Jan 26, 2013
@jeremy jeremy Update CHANGELOG for #499. Group pull requests by category: feature/p…
…erf/bugfix/housekeeping.
cd9e584
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment