New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popup is entirely gray in Firefox for Android #27

Closed
da2x opened this Issue Jul 10, 2018 · 4 comments

Comments

Projects
None yet
2 participants
@da2x
Copy link

da2x commented Jul 10, 2018

No visible content except for all gray background. Popup has title from /index.html.

BATify version: 1.0.4
Browser: Firefox 61.0
OS: Android 8.1 June 2018
Device: TA-1046 (Nokia 7 Plus)
@mikel2000

This comment has been minimized.

Copy link
Owner

mikel2000 commented Jul 10, 2018

Do I guess right, that this problem doesn't occur if BATify is disabled?

@da2x

This comment has been minimized.

Copy link
Author

da2x commented Jul 10, 2018

When loading extension:

E: Batify: ERROR: init failed: TypeError: windows is undefined. background.js:67:10

When opening popup:

W: Scripts may not close windows that were not opened by script. popup.js:29:15
E: config is undefined index.js:193
E: Unchecked lastError value: Error: Could not establish connection. Receiving end does not exist. index.js:173
@da2x

This comment has been minimized.

Copy link
Author

da2x commented Jul 10, 2018

This is a regression from #22 and #23. The browser.windows API is unavailable on Firefox for Android (there can only be one window and you can’t manipulate it – a lightweight API variant is being considered).

#22 and #23 should be reverted in favor of a solution built on document.visibilityState which would give much better results on desktop on all OSes and also works on mobile. See this suggested implementation for tracking time-on-page onpageunload.

@mikel2000

This comment has been minimized.

Copy link
Owner

mikel2000 commented Jul 10, 2018

Thanks for checking this! The problem is caused by missing browser.windows API on Firefox for Android. As I don't like to create an Android specific version, I disabled now BATify for Firefox for Android. Sorry for that, I should have disabled Android initially, as I never tested it. It is enabled by default when you upload an extension.

@mikel2000 mikel2000 closed this Jul 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment