Match current PR in esphome #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR submitted to ESPHome. These are the first round of requested changes. Lots of logging changes move to static inline functions model is now required. This allowed runtime validation to be removed in favor of compile time validation. make actions consistent.
This reverts commit e683819.
Updated set_software_version and set_hardware_version to take const std::string& instead of std::string, improving efficiency by avoiding unnecessary string copies.
Remove orphaned motion binary_sensor Correct reported occupancy when VERBOSE logging is enabled Remove state is changed logic around sensor and binary_sensor reporting. Makes initial updates quicker Corrected LED state not written to flash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There have been a few changes in the PR