Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds fallback listener to manage other drawer items with the NavController #2681

Merged
merged 2 commits into from
Nov 23, 2020
Merged

Adds fallback listener to manage other drawer items with the NavController #2681

merged 2 commits into from
Nov 23, 2020

Conversation

francescogatto
Copy link

Added: adds a fallback listener to manage other drawer items with the NavController

@mikepenz mikepenz changed the title Added: adds fallback listener to manage other drawer items with the N… Adds fallback listener to manage other drawer items with the NavController Nov 23, 2020
@mikepenz mikepenz merged commit c9b3c4c into mikepenz:develop Nov 23, 2020
@mikepenz
Copy link
Owner

thank you so much!

Copy link
Author

@francescogatto francescogatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You missed a bracket during the merge.. so the build is broken..
Thanks!

@francescogatto francescogatto deleted the feauture/2672 branch November 23, 2020 15:53
@mikepenz
Copy link
Owner

@francescogatto thank you so much for the PR.

I fixed that in some additional cleanup locally in my branch, but couldn't identify to fix it in the PR, the fix is part of the merge though :)

Didn't want to reopen a new PR to have this count for you as a contribution.

just for sanity I am having a build re-running now to see if all checks pass

@francescogatto
Copy link
Author

It's my first time contributing to GitHub.. deleting the branch I lost my contribution? Anyway no problem, the important is that everything works :)

@mikepenz
Copy link
Owner

Great job! Congrats to your first contribution on GitHub

So I can't modify your branch as it's in your fork, but as I wanted to apply some changes I did this locally before merging in. Sadly I did a mistake when doing the merge resolving in the web UI of github.

Here you can find the changes I did locally before merging: 31f3032

@francescogatto
Copy link
Author

Ok! Thanks!
Nice job with this amazing library!

Ciao! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants