Just some minor changes. Totally untested. #3

Merged
merged 5 commits into from Mar 19, 2013

Conversation

Projects
None yet
2 participants

Added a link to the actual crossfit games profile page.
Tweaked a few of the xpath iterations to use Ruby #collect method instead of #each and shoving into array. #collect and #map are synonyms. My general preference is when you are just grabbing one attribute from the items in the collection, I think of that as "collect," meaning... go and collect all these attributes. I would use map when I wan to more or less transform a collection into another collection. I think of it like go and map this collection to something else. But like I said, they both do the same thing.

.collect(&:text) is just shorthand for .collect { |score| score.text }

@mikepmunroe mikepmunroe added a commit that referenced this pull request Mar 19, 2013

@mikepmunroe mikepmunroe Merge pull request #3 from davekaro/master
Just some minor changes. Totally untested.
9ef3225

@mikepmunroe mikepmunroe merged commit 9ef3225 into mikepmunroe:master Mar 19, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment