Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue in algorithm for convert time from Decimal to calendar #2

Closed
wild-swift opened this issue May 7, 2012 · 3 comments
Closed

Issue in algorithm for convert time from Decimal to calendar #2

wild-swift opened this issue May 7, 2012 · 3 comments

Comments

@wild-swift
Copy link

If local time variable will be less then 0, in method SolarEventCalculator.getLocalTimeAsCalendar(), result will be incorrect.
@mikereedell
Copy link
Owner

Thanks for reporting this.

Do you have a use case for the error? I can duplicate it in a unit test but can't replicate the condition using real-world test data.

@wild-swift
Copy link
Author

I found this issue when I tried to calculate official sunrise time for my place (Novosibirsk, Russia) yesterday.
latitude = 55.03
longitude = 82.91
date = 07 may 2012
correct sunrise time is 22:35 GMT

mikereedell added a commit that referenced this issue May 9, 2012
@mikereedell
Fix for issue #2: Error computing sunrise for a different timezone wh…
68cf9b1 
…en sunrise occurs on a different day. Added testdata for this case with Lat/Long of Novosibirsk, Russia and target timezone of GMT.
@mikereedell
Copy link
Owner

The latest commit fixes this issue.

-Mike

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mikereedell @wild-swift