Issue in algorithm for convert time from Decimal to calendar #2

Closed
wild-swift opened this Issue May 7, 2012 · 3 comments

Projects

None yet

2 participants

@wild-swift

If local time variable will be less then 0, in method SolarEventCalculator.getLocalTimeAsCalendar(), result will be incorrect.

@mikereedell
Owner

Thanks for reporting this.

Do you have a use case for the error? I can duplicate it in a unit test but can't replicate the condition using real-world test data.

@wild-swift

I found this issue when I tried to calculate official sunrise time for my place (Novosibirsk, Russia) yesterday.
latitude = 55.03
longitude = 82.91
date = 07 may 2012
correct sunrise time is 22:35 GMT

@mikereedell mikereedell added a commit that referenced this issue May 9, 2012
@mikereedell Fix for issue #2: Error computing sunrise for a different timezone wh…
…en sunrise occurs on a different day. Added testdata for this case with Lat/Long of Novosibirsk, Russia and target timezone of GMT.
68cf9b1
@mikereedell
Owner

The latest commit fixes this issue.

-Mike

@mikereedell mikereedell closed this May 9, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment