Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upTweaks #5
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
mikescamell
Mar 7, 2017
Owner
Hi @jonathan-caryl, thanks for your comment and also for doing these fixes! I've recently updated the master branch with some fixes based on issue #2 and #3. I think this mainly effects the Adapter which you also fixed. I'll look at resolving the conflicts and getting this merged in when I can. Obviously it takes some more time as any changes here need to be reflected in my blog posts.
|
Hi @jonathan-caryl, thanks for your comment and also for doing these fixes! I've recently updated the master branch with some fixes based on issue #2 and #3. I think this mainly effects the Adapter which you also fixed. I'll look at resolving the conflicts and getting this merged in when I can. Obviously it takes some more time as any changes here need to be reflected in my blog posts. |
jonathan-caryl
added some commits
Mar 3, 2017
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
jonathan-caryl
Mar 7, 2017
Contributor
Hey @mikescamell I've pulled your updates from master and rebased my changes.
|
Hey @mikescamell I've pulled your updates from |
jonathan-caryl commentedMar 6, 2017
Hi,
I read your articles after they were linked in Android Weekly. Good stuff, easy to read. I downloaded the code and saw a few things that could be tidied up. I've bunched all these up in a single PR, if you'd like to have some bits but no others I can split things up.