Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaks #5

Merged
merged 9 commits into from Mar 19, 2017
Merged

Tweaks #5

merged 9 commits into from Mar 19, 2017

Conversation

@jonathan-caryl
Copy link
Contributor

jonathan-caryl commented Mar 6, 2017

Hi,
I read your articles after they were linked in Android Weekly. Good stuff, easy to read. I downloaded the code and saw a few things that could be tidied up. I've bunched all these up in a single PR, if you'd like to have some bits but no others I can split things up.

@mikescamell
Copy link
Owner

mikescamell commented Mar 7, 2017

Hi @jonathan-caryl, thanks for your comment and also for doing these fixes! I've recently updated the master branch with some fixes based on issue #2 and #3. I think this mainly effects the Adapter which you also fixed. I'll look at resolving the conflicts and getting this merged in when I can. Obviously it takes some more time as any changes here need to be reflected in my blog posts.

@jonathan-caryl jonathan-caryl force-pushed the jonathan-caryl:tweaks branch from ae36150 to 77d3e68 Mar 7, 2017
@jonathan-caryl
Copy link
Contributor Author

jonathan-caryl commented Mar 7, 2017

Hey @mikescamell I've pulled your updates from master and rebased my changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.