Tweaks #5

Merged
merged 9 commits into from Mar 19, 2017

Conversation

Projects
None yet
2 participants
@jonathan-caryl
Contributor

jonathan-caryl commented Mar 6, 2017

Hi,
I read your articles after they were linked in Android Weekly. Good stuff, easy to read. I downloaded the code and saw a few things that could be tidied up. I've bunched all these up in a single PR, if you'd like to have some bits but no others I can split things up.

@mikescamell

This comment has been minimized.

Show comment
Hide comment
@mikescamell

mikescamell Mar 7, 2017

Owner

Hi @jonathan-caryl, thanks for your comment and also for doing these fixes! I've recently updated the master branch with some fixes based on issue #2 and #3. I think this mainly effects the Adapter which you also fixed. I'll look at resolving the conflicts and getting this merged in when I can. Obviously it takes some more time as any changes here need to be reflected in my blog posts.

Owner

mikescamell commented Mar 7, 2017

Hi @jonathan-caryl, thanks for your comment and also for doing these fixes! I've recently updated the master branch with some fixes based on issue #2 and #3. I think this mainly effects the Adapter which you also fixed. I'll look at resolving the conflicts and getting this merged in when I can. Obviously it takes some more time as any changes here need to be reflected in my blog posts.

@jonathan-caryl

This comment has been minimized.

Show comment
Hide comment
@jonathan-caryl

jonathan-caryl Mar 7, 2017

Contributor

Hey @mikescamell I've pulled your updates from master and rebased my changes.

Contributor

jonathan-caryl commented Mar 7, 2017

Hey @mikescamell I've pulled your updates from master and rebased my changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment