Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upTweaks #5
Merged
Tweaks #5
Conversation
|
Hi @jonathan-caryl, thanks for your comment and also for doing these fixes! I've recently updated the master branch with some fixes based on issue #2 and #3. I think this mainly effects the Adapter which you also fixed. I'll look at resolving the conflicts and getting this merged in when I can. Obviously it takes some more time as any changes here need to be reflected in my blog posts. |
|
Hey @mikescamell I've pulled your updates from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jonathan-caryl commentedMar 6, 2017
Hi,
I read your articles after they were linked in Android Weekly. Good stuff, easy to read. I downloaded the code and saw a few things that could be tidied up. I've bunched all these up in a single PR, if you'd like to have some bits but no others I can split things up.