Skip to content

Agreeable to adding option for "vX.Y.Z" style tagging? #9

Closed
fnichol opened this Issue Mar 1, 2013 · 9 comments

4 participants

@fnichol
fnichol commented Mar 1, 2013

I can help with the work on this, but would much prefer if tagged releases of my cookbooks were of the form "v1.0.4" (vs. "1.0.4"). This allows you to sort and differentiate all release tags from other arbitrary ones. It's also the default style that Bundler and Jeweler use when releasing gems.

An opt-in flag is fine by me; it's about the only blocker for me to use this for all cookbook releases.

Thanks!

@miketheman
Owner

I'm agreeable to changing this, but would ask for input form @jtimberman & @schisamo who are users of this.

I don't know if a flag is the way to go - the idea of having a prescribed method is appealing, do Bundler/Jeweler allow you to override the defaults?

@schisamo
schisamo commented Mar 1, 2013

@miketheman @fnichol so my 2 cents is this: how you name your git tags is a personal choice (defect?), shouldn't really affect the community standards. I think the more important issue is just having a mature release process the community can rally around.

I'm :+1: for this, if only for the reason we get @fnichol using this plugin! :smile:

@jtimberman

Yeah, this is fine to me.

@miketheman
Owner

So, to summarize, I will change the tag that is created to be v#{version} instead of #{version}.

Anything else? If no responses are received within 48 hours, I will proceed as described.

@schisamo
@fnichol
@miketheman
Owner

I haven't had much time to dedicate to this change, but am open to pulls on this topic.

Also, if you feel like writing a test or two, that would help get me started on proper testing/refactoring this code.

@miketheman miketheman was assigned Apr 5, 2013
@miketheman
Owner

@fnichol, @jtimberman, @schisamo : please take a look at this branch: master...tagprefix

Would really be helpful to have more eyes on this. It also takes a stab at starting some rspec, oh boy.

@miketheman
Owner

Released in knife-community version 0.2.0.

@miketheman miketheman closed this May 3, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.