Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reverse proxy caching #285

Closed
wants to merge 5 commits into from
Closed

Add reverse proxy caching #285

wants to merge 5 commits into from

Conversation

azretd
Copy link

@azretd azretd commented Oct 16, 2014

No description provided.

@@ -72,6 +72,9 @@ http {
client_max_body_size <%= node['nginx']['client_max_body_size'] %>;
<% end -%>

<% if node['nginx']['reverse_proxy_caching'] == 'on' -%>
proxy_cache_path <%= node['nginx']['proxy_cache_path'] %>;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a <% end -%> missing to closes the if.

Also what do you think about only testing for presence of the node['nginx']['reverse_proxy_caching'] attribute, instead of equality testing for the value "on"(like done with the <% if node['nginx']['enable_rate_limiting'] -%> below and corresponding attribute).

@azretd
Copy link
Author

azretd commented Oct 16, 2014

Took in changes from your comment

@miketheman
Copy link
Contributor

@azretd Can you squash these commits? 5 seem a bit hefty for the amount of change here.
Also, adding tests are also welcomed.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling e2e2175 on azretd:feature-reverse-proxy into * on miketheman:master*.

@lock
Copy link

lock bot commented Apr 25, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants