Don't include_recipe passenger in repo recipe

[donaldguy]

Doing this include at this point, before nginx package is installed, breaks default or package recipe on first run if using passenger repos (because config dir doesn't yet exist when writing passenger.conf). It does mean you have to include_recipe 'nginx::passenger' later yourself.

This doesn't seem unreasonable, but would account to a breaking change for people who were depending on implicit inclusion (though the packages and config files are likely already in place for them)

A safer version of this would do the include at this point if nginx already installed but defer it to end of package recipe if first-install

Another alternative might be to switch the writing of the config to a delayed notification off ... something

A super ugly workaround with the current cookbook for an initial install can be achieved as follows:

ignore_further_includes = run_context.send(:loaded_recipes_hash)
ignore_further_includes['nginx::passenger'] = true
include_recipe 'nginx'
ignore_further_includes.delete('nginx::passenger')

---

This change is

[aerodynamik]

+1 for this change

[tas50]

Thanks for opening this PR. With the merge of the chef_nginx codebase back into the nginx cookbook I believe it’s no longer necessary. I’m going to close this out now, and I hope you can check out the massive changes that landed on master here #435

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.