Permalink
Browse files

fast/events/message-port-clone.html hits ASSERT in Debug (usually in …

…later tests)


https://bugs.webkit.org/show_bug.cgi?id=85811

Patch by Li Yin <li.yin@intel.com> on 2012-09-01
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

When MessagePort invoked close function, the close status is needed to set,
regardless of whether the port is cloned or not.

Tests: fast/events/message-port-clone.html
       fast/events/message-port-close.html

* dom/MessagePort.cpp:
(WebCore::MessagePort::close): Must set m_closed to be true.

LayoutTests:

* platform/gtk/TestExpectations:
* platform/mac/Skipped:
* platform/qt-4.8/TestExpectations:
* platform/qt-mac/TestExpectations:
* platform/qt/TestExpectations:
* platform/win/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127380 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information...
commit-queue
commit-queue committed Sep 1, 2012
1 parent 1623b56 commit 5d85405e7d4d662591f3b93130e381e180d41d42
View
@@ -1,3 +1,17 @@
+2012-09-01 Li Yin <li.yin@intel.com>
+
+ fast/events/message-port-clone.html hits ASSERT in Debug (usually in later tests)
+ https://bugs.webkit.org/show_bug.cgi?id=85811
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ * platform/gtk/TestExpectations:
+ * platform/mac/Skipped:
+ * platform/qt-4.8/TestExpectations:
+ * platform/qt-mac/TestExpectations:
+ * platform/qt/TestExpectations:
+ * platform/win/Skipped:
+
2012-09-01 Xianzhu Wang <wangxianzhu@chromium.org>
[Chromium-Android] Upstream layout test expectations (Part 4)
@@ -443,8 +443,6 @@ BUGWK92942 SKIP : fast/events/constructors/device-proximity-event-constructor.ht
BUGWK74297 DEBUG : http/tests/security/cross-origin-xsl-redirect-BLOCKED.html = CRASH PASS
-BUGWK85811 DEBUG : fast/events/message-port-close.html = CRASH PASS
-
BUGWK86443 : plugins/npruntime/delete-plugin-within-getProperty.html = CRASH
BUGWK86443 DEBUG : plugins/npruntime/delete-plugin-within-invoke.html = CRASH
@@ -872,10 +872,6 @@ fast/canvas/webgl/tex-image-and-sub-image-2d-with-video-rgb565.html
fast/canvas/webgl/tex-image-and-sub-image-2d-with-video-rgba4444.html
fast/canvas/webgl/tex-image-and-sub-image-2d-with-video-rgba5551.html
-# Asserts in MessagePort::contextDestroyed
-# https://bugs.webkit.org/show_bug.cgi?id=85811
-fast/events/message-port-clone.html
-
# Times out without keyboard interaction
# https://bugs.webkit.org/show_bug.cgi?id=87748
fast/forms/select/optgroup-clicking.html
@@ -163,8 +163,6 @@ BUGWK91376 : http/tests/security/sandboxed-iframe-modify-self.html = TEXT PASS
BUGWK91379 : http/tests/security/contentSecurityPolicy/policy-does-not-affect-child.html = TEXT PASS
BUGWK91379 : http/tests/security/contentSecurityPolicy/object-src-none-allowed.html = TEXT PASS
-BUGWK85811 DEBUG : fast/events/message-port-close.html = CRASH
-
// Needs rebaseline after https://bugs.webkit.org/show_bug.cgi?id=80219
BUGWK80219 : compositing/overflow/clip-descendents.html = TEXT
@@ -163,8 +163,6 @@ BUGWK91376 : http/tests/security/sandboxed-iframe-modify-self.html = TEXT PASS
BUGWK91379 : http/tests/security/contentSecurityPolicy/policy-does-not-affect-child.html = TEXT PASS
BUGWK91379 : http/tests/security/contentSecurityPolicy/object-src-none-allowed.html = TEXT PASS
-BUGWK85811 DEBUG : fast/events/message-port-close.html = CRASH
-
// Needs rebaseline after https://bugs.webkit.org/show_bug.cgi?id=80219
BUGWK80219 : compositing/overflow/clip-descendents.html = TEXT
@@ -123,8 +123,6 @@ BUGWK91376 : http/tests/security/sandboxed-iframe-modify-self.html = TEXT PASS
BUGWK91379 : http/tests/security/contentSecurityPolicy/policy-does-not-affect-child.html = TEXT PASS
BUGWK91379 : http/tests/security/contentSecurityPolicy/object-src-none-allowed.html = TEXT PASS
-BUGWK85811 DEBUG : fast/events/message-port-close.html = CRASH
-
// Needs rebaseline after https://bugs.webkit.org/show_bug.cgi?id=80219
BUGWK80219 : compositing/overflow/clip-descendents.html = TEXT
@@ -1867,10 +1867,6 @@ compositing/backing/no-backing-foreground-layer.html
# https://bugs.webkit.org/show_bug.cgi?id=88150
compositing/geometry/clipping-foreground.html
-# Asserts in MessagePort::contextDestroyed
-# https://bugs.webkit.org/show_bug.cgi?id=85811
-fast/events/message-port-clone.html
-
# Require rebaseline after bug 88171
# https://bugs.webkit.org/show_bug.cgi?id=88171
fast/block/float/independent-align-positioning.html
View
@@ -1,3 +1,19 @@
+2012-09-01 Li Yin <li.yin@intel.com>
+
+ fast/events/message-port-clone.html hits ASSERT in Debug (usually in later tests)
+ https://bugs.webkit.org/show_bug.cgi?id=85811
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ When MessagePort invoked close function, the close status is needed to set,
+ regardless of whether the port is cloned or not.
+
+ Tests: fast/events/message-port-clone.html
+ fast/events/message-port-close.html
+
+ * dom/MessagePort.cpp:
+ (WebCore::MessagePort::close): Must set m_closed to be true.
+
2012-09-01 Andreas Kling <kling@webkit.org>
Share inline style between cloned Nodes (copy on write.)
@@ -133,9 +133,8 @@ void MessagePort::start()
void MessagePort::close()
{
- if (!isEntangled())
- return;
- m_entangledChannel->close();
+ if (isEntangled())
+ m_entangledChannel->close();
m_closed = true;
}

0 comments on commit 5d85405

Please sign in to comment.