Skip to content
This repository

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
  • 27 commits
  • 109 files changed
  • 0 comments
  • 12 contributors
Jun 10, 2012
Jer Noble jernoble WebCore should use a single definition of an invalid media time.
https://bugs.webkit.org/show_bug.cgi?id=88572

Reviewed by Eric Carlson.

No new tests; no change in functionality, so covered by existing tests.

Add a new, universal definition for an invalid media time:
* platform/graphics/MediaPlayer.h:
(WebCore::MediaPlayer::invalidTime):

Use this new definition instead of the hodge podge of (identical) local
definitions for an invalid media time:
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::invalidateCachedTime):
(WebCore::HTMLMediaElement::currentTime):
(WebCore::HTMLMediaElement::initialTime):
(WebCore::HTMLMediaElement::playbackProgressTimerFired):
(WebCore::HTMLMediaElement::prepareMediaFragmentURI):
(WebCore::HTMLMediaElement::applyMediaFragmentURI):
* html/MediaFragmentURIParser.cpp:
(WebCore::MediaFragmentURIParser::invalidTimeValue):
(WebCore::MediaFragmentURIParser::MediaFragmentURIParser):
(WebCore::MediaFragmentURIParser::startTime):
(WebCore::MediaFragmentURIParser::endTime):
(WebCore::MediaFragmentURIParser::parseTimeFragment):
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation):
(WebCore::MediaPlayerPrivateAVFoundation::duration):
(WebCore::MediaPlayerPrivateAVFoundation::seeking):
(WebCore::MediaPlayerPrivateAVFoundation::seekCompleted):
(WebCore::MediaPlayerPrivateAVFoundation::invalidateCachedDuration):
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
(MediaPlayerPrivateAVFoundation):
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::platformDuration):
* platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::duration):
(WebCore::MediaPlayerPrivateQTKit::updateStates):
(WebCore::MediaPlayerPrivateQTKit::timeChanged):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119938 268f45cc-cd09-0410-ab3c-d52691b4dbfc
d670c54
Jer Noble jernoble Add logging functions to MediaPlayerPrivateQTKit.
https://bugs.webkit.org/show_bug.cgi?id=88425

Reviewed by Eric Carlson.

No new tests; adds logging functions to aide debugging.

MediaPlayerPrivateQTKit should emit the same kind of logging messages as
other MediaPlayerPrivate engines to aide in debugging.

Distinguish between loadedRangesChanged() and loadStateChanged() for logging
purposes:
* platform/graphics/mac/MediaPlayerPrivateQTKit.h:
* platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::loadedRangesChanged):
(-[WebCoreMovieObserver loadedRangesChanged:]):

Add LOG messages for each of the following functions:
* platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::~MediaPlayerPrivateQTKit):
(WebCore::MediaPlayerPrivateQTKit::createQTMovie):
(WebCore::MediaPlayerPrivateQTKit::createQTMovieView):
(WebCore::MediaPlayerPrivateQTKit::detachQTMovieView):
(WebCore::MediaPlayerPrivateQTKit::createQTVideoRenderer):
(WebCore::MediaPlayerPrivateQTKit::destroyQTVideoRenderer):
(WebCore::MediaPlayerPrivateQTKit::createQTMovieLayer):
(WebCore::MediaPlayerPrivateQTKit::destroyQTMovieLayer):
(WebCore::MediaPlayerPrivateQTKit::setUpVideoRendering):
(WebCore::MediaPlayerPrivateQTKit::tearDownVideoRendering):
(WebCore::MediaPlayerPrivateQTKit::load):
(WebCore::MediaPlayerPrivateQTKit::prepareToPlay):
(WebCore::MediaPlayerPrivateQTKit::play):
(WebCore::MediaPlayerPrivateQTKit::pause):
(WebCore::MediaPlayerPrivateQTKit::seek):
(WebCore::MediaPlayerPrivateQTKit::cancelSeek):
(WebCore::MediaPlayerPrivateQTKit::setVolume):
(WebCore::MediaPlayerPrivateQTKit::setRate):
(WebCore::MediaPlayerPrivateQTKit::setPreservesPitch):
(WebCore::MediaPlayerPrivateQTKit::cancelLoad):
(WebCore::MediaPlayerPrivateQTKit::prepareForRendering):
(WebCore::MediaPlayerPrivateQTKit::updateStates):
(WebCore::MediaPlayerPrivateQTKit::loadStateChanged):
(WebCore::MediaPlayerPrivateQTKit::rateChanged):
(WebCore::MediaPlayerPrivateQTKit::sizeChanged):
(WebCore::MediaPlayerPrivateQTKit::timeChanged):
(WebCore::MediaPlayerPrivateQTKit::didEnd):
(WebCore::MediaPlayerPrivateQTKit::clearMediaCache):
(WebCore::MediaPlayerPrivateQTKit::clearMediaCacheForSite):
(WebCore::MediaPlayerPrivateQTKit::disableUnsupportedTracks):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119939 268f45cc-cd09-0410-ab3c-d52691b4dbfc
dbc22a6
Jer Noble jernoble REGRESSION: Setting invalid media "src" does not cause "error" event
https://bugs.webkit.org/show_bug.cgi?id=88423

Reviewed by Eric Carlson.

Source/WebCore:

Test: http/tests/media/video-src-invalid-error.html

Two problems here.  When the loadTimer is scheduled, the m_pendingLoadFlags
variable is set to specify what type of load is scheduled.  It is cleared
when the loadTimer fires. But, when prepareForLoad() stops the loadTimer,
it does not clear the m_pendingLoadFlags variable, so the next time
scheduleLoad() is called (when the src is changed to an invalid URL)
prepareForLoad() is not called again.

Second problem: Due to a bug in QTKit (<rdar://problem/11606415>), the
QTMovieLoadStateChangedNotification is never fired for an invalid http
URL if QTMovieOpenAsyncRequiredAttribute:YES is not passed when creating
the QTMovie.

Add a new utility method which both stops the m_loadTimer and clears the
m_pendingLoadFlags, and use it in all the places where m_loadTimer was
stopped explicitly:

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::prepareForLoad):
(WebCore::HTMLMediaElement::stopLoadTimer): Added
(WebCore::HTMLMediaElement::userCancelledLoad):
* html/HTMLMediaElement.h:

And pass QTMovieOpenAsyncRequiredAttribute:YES when creating the QTMovie:

* platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::commonMovieAttributes):

LayoutTests:

* http/tests/media/video-src-invalid-error-expected.txt: Added.
* http/tests/media/video-src-invalid-error.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119940 268f45cc-cd09-0410-ab3c-d52691b4dbfc
3caa13f
commit-queue [EFL] Skip fast/dom/frame-loading-via-document-write.html
https://bugs.webkit.org/show_bug.cgi?id=88737

Unreviewed EFL gardening. Skipping test that is flaky after r119788.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-06-10

* platform/efl/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119941 268f45cc-cd09-0410-ab3c-d52691b4dbfc
a87d3f7
commit-queue [EFL][GTK] media/track/track-cue-rendering-inner-timestamps.html is f…
…ailing


https://bugs.webkit.org/show_bug.cgi?id=88725

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-06-10
Reviewed by Eric Carlson.

* media/track/track-cue-rendering-inner-timestamps.html: Round the timestamp values
so that the test passes for EFL and GTK ports.
* platform/efl/TestExpectations: Unskip test.
* platform/gtk/TestExpectations: Unskip test.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119942 268f45cc-cd09-0410-ab3c-d52691b4dbfc
d1978d6
Darin Adler Some additional tweaks to keep TreeShared code simple/clean
https://bugs.webkit.org/show_bug.cgi?id=88738

Reviewed by Adam Barth.

* platform/TreeShared.h: Make constructor and destructor both protected.
It's slightly dangerous to have a public non-virtual destructor, and there
is no reason it needs to be public.
(WebCore::TreeShared::~TreeShared): Make debug-only destructor non-virtual;
we were getting no value from it being virtual. Now that it's non-virtual,
there is no need to use an #if on it since it's an empty inline destructor
in non-debug builds.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119943 268f45cc-cd09-0410-ab3c-d52691b4dbfc
4ca56aa
commit-queue Removing mixed content tests' dependency on WebKitBlobBuilder:
https://bugs.webkit.org/show_bug.cgi?id=88736

http/tests/security/mixedContent/blob-url-in-iframe.html and
http/tests/security/mixedContent/filesystem-url-in-iframe.html both
relied on WebKitBlobBuilder, which is disabled on some builds. `new
Blob()` is the new hotness that these tests should be using instead. This
patch migrates both tests to the new API.

It also reenables blob-url-in-iframe.html on mac (filesystem-url-in-iframe.html
remains disabled, as the filesystem APIs are disabled entirely).

Patch by Mike West <mkwst@chromium.org> on 2012-06-10
Reviewed by Adam Barth.

* http/tests/security/mixedContent/blob-url-in-iframe.html:
* http/tests/security/mixedContent/filesystem-url-in-iframe.html:
* platform/mac/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119944 268f45cc-cd09-0410-ab3c-d52691b4dbfc
162102e
commit-queue Access control allow lists starting with a comma are parsed incorrect…
…ly (CORS)


https://bugs.webkit.org/show_bug.cgi?id=88461

Patch by Pablo Flouret <pablof@motorola.com> on 2012-06-10
Reviewed by Adam Barth.

Source/WebCore:

The parsing algorithm would stop parsing at the first comma (being an
empty entry, of sorts) and bail out, effectively ignoring the whole
header.

Test: http/tests/xmlhttprequest/access-control-allow-lists-starting-with-comma.html

* loader/CrossOriginPreflightResultCache.cpp:
(WebCore::parseAccessControlAllowList):

LayoutTests:

* http/tests/xmlhttprequest/access-control-allow-lists-starting-with-comma-expected.txt: Added.
* http/tests/xmlhttprequest/access-control-allow-lists-starting-with-comma.html: Added.
* http/tests/xmlhttprequest/resources/access-control-allow-lists.php: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119945 268f45cc-cd09-0410-ab3c-d52691b4dbfc
40d1cc7
Ryosuke Niwa rniwa Expose layoutTestController as testRunner
https://bugs.webkit.org/show_bug.cgi?id=88210

Reviewed by Darin Adler.

Tools:

* DumpRenderTree/LayoutTestController.cpp:
(LayoutTestController::makeWindowObject):
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::bindJSObjectsToWindow):
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::initJSObjects):
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::makeWindowObject):

LayoutTests:

Add a test for testRunner object.

* fast/harness/testrunner-object-expected.txt: Added.
* fast/harness/testrunner-object.html: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119946 268f45cc-cd09-0410-ab3c-d52691b4dbfc
99c316c
Jun 11, 2012
commit-queue [BlackBerry] Possible to clobber httponly cookie.
https://bugs.webkit.org/show_bug.cgi?id=86067

Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-06-10
Reviewed by Rob Buis.

Source/WebCore:

If a cookie is set by javaScript and there is already a same httpOnly cookie in cookieManager,
we should reject it. If it has a httpOnly property, we reject it, too.

Test: http/tests/cookies/js-get-and-set-http-only-cookie.html

* platform/blackberry/CookieJarBlackBerry.cpp:
(WebCore::setCookies):
* platform/blackberry/CookieManager.cpp:
(WebCore::CookieManager::setCookies):
(WebCore::CookieManager::checkAndTreatCookie):
(WebCore::CookieManager::addCookieToMap):
(WebCore::CookieManager::setPrivateMode):
* platform/blackberry/CookieManager.h:
* platform/blackberry/CookieMap.cpp:
(WebCore::CookieMap::addOrReplaceCookie):
(WebCore::CookieMap::removeCookie):
* platform/blackberry/CookieMap.h:
(CookieMap):

LayoutTests:

* http/tests/cookies/js-get-and-set-http-only-cookie-expected.txt: Added.
* http/tests/cookies/js-get-and-set-http-only-cookie.html: Added.
* platform/chromium/http/tests/cookies/js-get-and-set-http-only-cookie-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119947 268f45cc-cd09-0410-ab3c-d52691b4dbfc
79ca33f
yosin [Forms] Introduce Decimal behind the InputNumber type
https://bugs.webkit.org/show_bug.cgi?id=88383

Reviewed by Kent Tamura.

Source/WebCore:

This patch introduces decimal arithmetic for steppable input types,
e.g. date, datetime, number, range, and so on, to avoid rounding error
caused by base 2 floating point representation, e.g. C/C++ double type.

Most of decimal arithmetic calculations are implemented in StepRange
class, replacing "double" with "Decimal", InputType::applyStep, and
InputType::stepFromRenderer.

Changes introduced by this patch are still intermediate state.
Following patch will replace InputNumber type to Decimal type for
completion of introducing decimal arithmetic.

Test: fast/forms/range/range-value-rounding.html

* html/BaseDateAndTimeInputType.cpp:
(WebCore::BaseDateAndTimeInputType::serialize): Changed for Decimal type.
(WebCore::BaseDateAndTimeInputType::serializeWithComponents): ditto.
* html/DateInputType.cpp:
(WebCore::DateInputType::createStepRange): Replaced NumberWithDecimalPlaces to InputNumber.
* html/DateTimeInputType.cpp:
(WebCore::DateTimeInputType::createStepRange): Replaced NumberWithDecimalPlaces to InputNumber.
* html/DateTimeLocalInputType.cpp:
(WebCore::DateTimeLocalInputType::createStepRange): Replaced NumberWithDecimalPlaces to InputNumber.
* html/InputType.cpp:
(WebCore::InputType::rangeUnderflow): Changed for Decimal type.
(WebCore::InputType::rangeOverflow): Changed for Decimal type.
(WebCore::InputType::minimum): Changed for Decimal type.
(WebCore::InputType::maximum): ditto.
(WebCore::InputType::isInRange): ditto.
(WebCore::InputType::isOutOfRange): ditto.
(WebCore::InputType::stepMismatch): ditto.
(WebCore::InputType::validationMessage): ditto.
(WebCore::InputType::parseToNumberOrNaN): ditto.
(WebCore::InputType::applyStep): ditto.
(WebCore::InputType::stepUpFromRenderer): ditto.
* html/InputType.h:
(InputType): Removed parseToNumberWIthDecimaplPlaces.
* html/MonthInputType.cpp:
(WebCore::MonthInputType::createStepRange): Changed for Decimal type.
* html/NumberInputType.cpp:
(WebCore::RealNumberRenderSize): Added for calculateRenderSize.
(WebCore::calculateRenderSize): Added. This function replacess lengthBeforeDecimalPoint.
(WebCore::NumberInputType::createStepRange): Changed for Decimal type.
(WebCore::NumberInputType::sizeShouldIncludeDecoration): Changed to use calculateRenderSize.
(WebCore::NumberInputType::parseToNumber): Changed for Decimal type.
(WebCore::NumberInputType::serialize): ditto.
* html/NumberInputType.h:
(NumberInputType): Removed parseToNumberWIthDecimaplPlaces.
* html/RangeInputType.cpp:
(WebCore::RangeInputType::createStepRange): Changed for Decimal type.
(WebCore::RangeInputType::handleKeydownEvent): ditto.
(WebCore::RangeInputType::parseToNumber): ditto.
(WebCore::RangeInputType::serialize): ditto.
* html/StepRange.cpp:
(WebCore::StepRange::StepRange): Removed decimal places and changed for Decimal type.
(WebCore::StepRange::acceptableError): Changed for Decimal type.
(WebCore::StepRange::alignValueForStep): ditto.
(WebCore::StepRange::clampValue): Changed for Decimal type and std::min/max.
(WebCore::StepRange::parseStep): Changed for Decimal type and removed NumberWithDecimalPlaces.
(WebCore::StepRange::stepMismatch): Changed for Decimal type.
(WebCore::convertDoubleToInputNumber): Changed to real implementation.
(WebCore::convertInputNumberToDouble):  Changed to real implementation.
* html/StepRange.h:
(InputNumber): Replacement of NumberWithDecimalPlaces.
(WebCore::StepRange::InputNumber::InputNumber):
* html/TimeInputType.cpp:
(WebCore::TimeInputType::createStepRange): Changed for Decimal type.
* html/WeekInputType.cpp:
(WebCore::WeekInputType::createStepRange): Changed for Decimal type.
* html/parser/HTMLParserIdioms.cpp:
(WebCore::serializeForNumberType): Added Decimal version.
(WebCore::parseToDecimalForNumberType): Added.
* html/parser/HTMLParserIdioms.h: Updated comments for parseToDoubleForNumberType.
* html/shadow/SliderThumbElement.cpp:
(WebCore::sliderPosition): Changed for Decimal type.

LayoutTests:

* fast/forms/range/range-value-rounding-expected.txt: Added.
* fast/forms/range/range-value-rounding.html: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119948 268f45cc-cd09-0410-ab3c-d52691b4dbfc
0794c71
Hayato Ito hayatoito An inheritance of '-webkit-user-modify' does not stop at shadow bound…
…ary.


https://bugs.webkit.org/show_bug.cgi?id=88514

Reviewed by Ryosuke Niwa.

Source/WebCore:

In StyleResolver::styleForElement(), we reset '-webkit-user-modify'
CSS property after inheriting a parent style, but that is not
enough.  We also have to reset '-webkit-user-modify' when we use a
cached result in applying matched properties.

Test: fast/dom/shadow/user-modify-inheritance.html

* css/StyleResolver.cpp:
(WebCore::StyleResolver::applyMatchedProperties):
(WebCore::StyleResolver::styleForElement):
* css/StyleResolver.h:
(StyleResolver):
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::inheritFrom):
* rendering/style/RenderStyle.h:

LayoutTests:

* fast/dom/shadow/user-modify-inheritance-expected.txt: Added.
* fast/dom/shadow/user-modify-inheritance.html: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119949 268f45cc-cd09-0410-ab3c-d52691b4dbfc
9a2a299
Dominic Cooney coonsta [Chromium] Unreviewed: Update
css3/font-feature-settings-rendering.html expectations to fail on
XP.

* platform/chromium/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119950 268f45cc-cd09-0410-ab3c-d52691b4dbfc
53b1bd4
Dominic Cooney coonsta [Chromium] Unreviewed: Update
css3/font-feature-settings-rendering.html again -- actually it may
pass if a particular DLL is installed. So expect PASS or
IMAGE+TEXT failure from this test.

* platform/chromium/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119951 268f45cc-cd09-0410-ab3c-d52691b4dbfc
9c86ada
Dominic Cooney coonsta [Chromium] Unreviewed: Rebaseline fixed-position-transform-composited…
…-page-scale on Linux, Win

These differ in antialiasing only, where there are already
platform differences antialiasing.

* platform/chromium-linux/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png:
* platform/chromium-win/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119952 268f45cc-cd09-0410-ab3c-d52691b4dbfc
614b98e
Dominic Cooney coonsta [Chromium] Unreviewed: Add expectations for svg-as-background-6.html
Like other SVG tests noted in bug 83303, this test fails on
Windows because it uses a sans-serif font where a serif font is
expected.

* platform/chromium/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119953 268f45cc-cd09-0410-ab3c-d52691b4dbfc
1867467
Kinuko Yasuda kinu Move Quota related code out of DOMWindow and into the quota/ folder
https://bugs.webkit.org/show_bug.cgi?id=88512

Patch by Kinuko Yasuda <kinuko@google.com> on 2012-06-07
Reviewed by Adam Barth.

No new tests: no visible changes.

* CMakeLists.txt:
* DerivedSources.cpp:
* DerivedSources.make:
* DerivedSources.pri:
* Modules/quota/DOMWindowQuota.cpp: Added.
* Modules/quota/DOMWindowQuota.h: Added.
* Modules/quota/DOMWindowQuota.idl: Added.
* Modules/quota/StorageInfo.cpp: Renamed from Source/WebCore/storage/StorageInfo.cpp.
* Modules/quota/StorageInfo.h: Renamed from Source/WebCore/storage/StorageInfo.h.
* Modules/quota/StorageInfo.idl: Renamed from Source/WebCore/storage/StorageInfo.idl.
* Modules/quota/StorageInfoErrorCallback.h: Renamed from Source/WebCore/storage/StorageInfoErrorCallback.h.
* Modules/quota/StorageInfoErrorCallback.idl: Renamed from Source/WebCore/storage/StorageInfoErrorCallback.idl.
* Modules/quota/StorageInfoQuotaCallback.h: Renamed from Source/WebCore/storage/StorageInfoQuotaCallback.h.
* Modules/quota/StorageInfoQuotaCallback.idl: Renamed from Source/WebCore/storage/StorageInfoQuotaCallback.idl.
* Modules/quota/StorageInfoUsageCallback.h: Renamed from Source/WebCore/storage/StorageInfoUsageCallback.h.
* Modules/quota/StorageInfoUsageCallback.idl: Renamed from Source/WebCore/storage/StorageInfoUsageCallback.idl.
* Target.pri:
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* WebCore.pri:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.vcproj/WebCoreCommon.vsprops:
* WebCore.vcproj/copyForwardingHeaders.cmd:
* WebCore.xcodeproj/project.pbxproj:
* page/DOMWindow.cpp:
* page/DOMWindow.h:
* page/DOMWindow.idl:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119954 268f45cc-cd09-0410-ab3c-d52691b4dbfc
0ba70e5
Sam Weinig Remove support for disconnected/excluded from search frames, they are…
… not used by Safari anymore


https://bugs.webkit.org/show_bug.cgi?id=88723

Reviewed by Dan Bernstein.

Source/WebCore:

* WebCore.exp.in:
Update export.
* editing/Editor.cpp:
(WebCore::Editor::rangeOfString):
(WebCore::Editor::countMatchesForText):
* editing/Editor.h:
(Editor):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::findFrameForNavigation):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::parent):
(WebCore::DOMWindow::top):
* page/EventHandler.cpp:
(WebCore::EventHandler::hitTestResultAtPoint):
* page/Frame.cpp:
(WebCore::Frame::Frame):
* page/Frame.h:
(Frame):
* page/FrameTree.cpp:
(WebCore::FrameTree::parent):
(WebCore::FrameTree::top):
* page/FrameTree.h:
(FrameTree):
* page/Location.cpp:
(WebCore::Location::ancestorOrigins):
* xml/XMLTreeViewer.cpp:
(WebCore::XMLTreeViewer::hasNoStyleInformation):
Update for the removal of disconnected frames and text search exclusions concepts.

Source/WebKit/mac:

* WebView/WebFrame.mm:
* WebView/WebFramePrivate.h:
Remove -[WebFrame _setIsDisconnected:] and -[WebFrame _setExcludeFromTextSearch:]

Source/WebKit/win:

* WebFrame.cpp:
(WebFrame::setIsDisconnected):
(WebFrame::setExcludeFromTextSearch):
Stop doing anything in these functions.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119955 268f45cc-cd09-0410-ab3c-d52691b4dbfc
4221808
Kinuko Yasuda kinu Using BlobBuilder should show a deprecation warning message (if it is…
… enabled)


https://bugs.webkit.org/show_bug.cgi?id=88644

Reviewed by Jian Li.

Source/WebCore:

Mac has already disabled BlobBuilder, but Chromium still has it.
We should start showing a warning to let people migrate to using Blob constructor.

Tests: fast/files/blob-builder-crash.html

* fileapi/WebKitBlobBuilder.cpp:
(WebCore):
(WebCore::WebKitBlobBuilder::create):
* fileapi/WebKitBlobBuilder.h:
(WebCore):
(WebKitBlobBuilder):
* fileapi/WebKitBlobBuilder.idl:

LayoutTests:

* fast/files/blob-builder-crash-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119956 268f45cc-cd09-0410-ab3c-d52691b4dbfc
27f52f6
commit-queue Unreviewed, rolling out r119955.
http://trac.webkit.org/changeset/119955
https://bugs.webkit.org/show_bug.cgi?id=88758

Breaks Chromium compile - Chromium depends on removed API
(Requested by dominicc on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-10

Source/WebCore:

* WebCore.exp.in:
* editing/Editor.cpp:
(WebCore::Editor::insideVisibleArea):
(WebCore):
(WebCore::Editor::firstVisibleRange):
(WebCore::Editor::lastVisibleRange):
(WebCore::Editor::nextVisibleRange):
(WebCore::Editor::rangeOfString):
(WebCore::Editor::countMatchesForText):
* editing/Editor.h:
(Editor):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::findFrameForNavigation):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::parent):
(WebCore::DOMWindow::top):
* page/EventHandler.cpp:
(WebCore::EventHandler::hitTestResultAtPoint):
* page/Frame.cpp:
(WebCore::Frame::Frame):
* page/Frame.h:
(Frame):
(WebCore::Frame::isDisconnected):
(WebCore):
(WebCore::Frame::setIsDisconnected):
(WebCore::Frame::excludeFromTextSearch):
(WebCore::Frame::setExcludeFromTextSearch):
* page/FrameTree.cpp:
(WebCore::FrameTree::parent):
(WebCore::FrameTree::top):
* page/FrameTree.h:
(FrameTree):
* page/Location.cpp:
(WebCore::Location::ancestorOrigins):
* xml/XMLTreeViewer.cpp:
(WebCore::XMLTreeViewer::hasNoStyleInformation):

Source/WebKit/mac:

* WebView/WebFrame.mm:
(-[WebFrame _setIsDisconnected:]):
(-[WebFrame _setExcludeFromTextSearch:]):
* WebView/WebFramePrivate.h:

Source/WebKit/win:

* WebFrame.cpp:
(WebFrame::setIsDisconnected):
(WebFrame::setExcludeFromTextSearch):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119957 268f45cc-cd09-0410-ab3c-d52691b4dbfc
5520a96
Ryuan Choi [EFL] Extract CursorMap from WidgetEfl.cpp.
https://bugs.webkit.org/show_bug.cgi?id=88633

Reviewed by Ryosuke Niwa.

In order to share CursorMap in WebKit/efl and UIProcess of WebKit2/Efl,
extract it and expose getEcoreCursor.

No new tests, refactoring only.

* platform/efl/EflScreenUtilities.cpp:
(WebCore):
(CursorMap):
(WebCore::CursorMap::cursor):
(WebCore::CursorMap::CursorMap):
(WebCore::getEcoreCursor):
* platform/efl/EflScreenUtilities.h:
(WebCore):
* platform/efl/WidgetEfl.cpp:
(WebCore::Widget::applyFallbackCursor):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119958 268f45cc-cd09-0410-ab3c-d52691b4dbfc
4d82ab5
commit-queue [EFL] Unskip http/tests/security/mixedContent/blob-url-in-iframe.html
https://bugs.webkit.org/show_bug.cgi?id=88752

Unreviewed EFL gardening. Unskip http/tests/security/mixedContent/blob-url-in-iframe.html
now that it no longer depends on the legacy blob builder (r119944).

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-06-11

* platform/efl/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119959 268f45cc-cd09-0410-ab3c-d52691b4dbfc
6de70ed
Hajime Morrita omo Spellchecker crash in async scenario.
https://bugs.webkit.org/show_bug.cgi?id=88617

Reviewed by Tony Chang.

SpellCheckRequest::invokeRequest() can be reached after the frame is detached.
SpellCheckRequest should ignore such a request since TextCheckerClient is not available
for detached Frames.

No new tests. It's hard to reproduce this.

* editing/SpellChecker.cpp:
(WebCore::SpellChecker::invokeRequest):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119960 268f45cc-cd09-0410-ab3c-d52691b4dbfc
ff46f64
Dominic Cooney coonsta [Chromium] Unreviewed: Remove expectations for passing tests
The flakiness dashboard indicates that
platform/chromium/virtual/gpu/canvas/philip/tests/2d.gradient.radial.cone.cylinder.html
and
platform/chromium/virtual/gpu/fast/canvas/canvas-currentColor.html
are passing on all platforms now.

* platform/chromium/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119961 268f45cc-cd09-0410-ab3c-d52691b4dbfc
153a418
commit-queue [JSC] Web Inspector: implement breaking from native callback
https://bugs.webkit.org/show_bug.cgi?id=43332

Patch by Peter Wang <peter.wang@torchmobile.com.cn> on 2012-06-11
Reviewed by Pavel Feldman.

These test cases were enabled:
LayoutTests/inspector/debugger/dom-breakpoints.html
LayoutTests/inspector/debugger/event-listener-breakpoints.html
LayoutTests/inspector/debugger/step-through-event-listeners.html
LayoutTests/inspector/debugger/xhr-breakpoints.html

* bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::breakProgram):
* bindings/js/ScriptDebugServer.h:
(WebCore::supportsNativeBreakpoints):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119962 268f45cc-cd09-0410-ab3c-d52691b4dbfc
362032f
commit-queue [EFL] skip http/tests/cookies/js-get-and-set-http-only-cookie.html te…
…st case


https://bugs.webkit.org/show_bug.cgi?id=88751

Unreviewed EFL gardening. Skip newly introduced test case that is failing
on most ports.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-06-11

* platform/efl/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119963 268f45cc-cd09-0410-ab3c-d52691b4dbfc
eb810c8
ossy13 ossy13 [Qt] Gardening, skip new failing tests.
Patch by Szilard Ledan <szledan@inf.u-szeged.hu> on 2012-06-11
Reviewed by Csaba Osztrogonác.

* platform/qt/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119964 268f45cc-cd09-0410-ab3c-d52691b4dbfc
22e66f0