Permalink
Browse files

Closes #3 (reported by espeed). Fixed the __request() method

returning r.json instead of r.json().

The problem stemmed from a change in the requests library documented in
in commit fe0b0a989fad80a300d2cf940d58370d13cc9e42 where r.json is
updated to r.json(). To prevent issues with updates in dependencies, I
locked the requests library to version 1.2.* in setup.py.
  • Loading branch information...
1 parent 4911d41 commit fc0597aafb1cb83c76e039370b1e0e180322f0e0 @mikexstudios committed Apr 30, 2013
Showing with 3 additions and 3 deletions.
  1. +1 −1 firebase/__init__.py
  2. +1 −1 requirements.txt
  3. +1 −1 setup.py
@@ -86,7 +86,7 @@ def __request(self, method, **kwargs):
r = requests.request(method, self.__url(), params=params, **kwargs)
r.raise_for_status() #throw exception if error
- return r.json
+ return r.json()
def __url(self):
View
@@ -1 +1 @@
-requests
+requests >=1.2.0,<1.2.99
View
@@ -8,7 +8,7 @@
author = 'Michael Huynh',
author_email = 'mike@mikexstudios.com',
url = 'http://github.com/mikexstudios/python-firebase',
- install_requires = ['requests'],
+ install_requires = ['requests >=1.2.0,<1.2.99'],
classifiers = [
'Programming Language :: Python',
'License :: OSI Approved :: BSD License',

0 comments on commit fc0597a

Please sign in to comment.