New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] skip tests using stream_lock when running on hhvm #82

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@Tuurlijk

Tuurlijk commented Jun 21, 2014

Skip certain tests using stream_lock when running under hhvm.

@mikey179

This comment has been minimized.

Owner

mikey179 commented Jun 22, 2014

I'm not sure it's a good idea to ignore those tests. Is stream_lock() not supported yet or will it never be supported?

@sgolemon

This comment has been minimized.

sgolemon commented Sep 13, 2014

HHVM supports stream_lock, so not sure why you'd skip 'em... facebook/hhvm@c1a8c93

@mikey179

This comment has been minimized.

Owner

mikey179 commented Sep 14, 2014

As HHVM supports stream_lock the tests should not be ignored than. Maybe someone wants to find out why the tests fail, I'll happily accept pull requests if something needs to be fixed to make it work with HHVM as well.

@mikey179 mikey179 closed this Sep 14, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment