[TASK] skip tests using stream_lock when running on hhvm #82

Closed
wants to merge 1 commit into
from

Projects

None yet

3 participants

@Tuurlijk

Skip certain tests using stream_lock when running under hhvm.

@mikey179
Owner

I'm not sure it's a good idea to ignore those tests. Is stream_lock() not supported yet or will it never be supported?

@sgolemon

HHVM supports stream_lock, so not sure why you'd skip 'em... facebook/hhvm@c1a8c93

@mikey179
Owner

As HHVM supports stream_lock the tests should not be ignored than. Maybe someone wants to find out why the tests fail, I'll happily accept pull requests if something needs to be fixed to make it work with HHVM as well.

@mikey179 mikey179 closed this Sep 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment