Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Twitter] [#1532] Add account URL to --write-metadata and expand t.co links in user descriptions #1787

Closed
wants to merge 3 commits into from

Conversation

Scripter17
Copy link
Contributor

It wouldn't make much sense to put these in separate pull requests so I just joined them

It's messy code and still needs to be tested but basically it

  1. Fixes t.co links in a user's bio when doing --write-metadata in the same way 41457db was done
  2. Adds the "here is my site" field to the written metadata since it was absent for some reason

Side note: The JSON for the t.co replacement stuff is really weird. If there's no t.co links in the bio user["entities"]["description"] is empty but for the "my site" link user["entities"]["url"] is just gone. You'd think it'd be a bit more consistent than that

@Scripter17
Copy link
Contributor Author

:/
:/

Why yes flake8, 84 *is* greater than 79
This is why people don't like linters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants