[Windows] Folder Name Sanitization Needed

[chrsmlls333]

Similar to #545 , there is an issue with tag variables that contain trailing ellipsis (...) being used for folder names and creating damaged, undeletable folders on Windows.

I am not sure how slashes and other non-permitted characters are handled or removed from new filenames, but there may need to be a final cleaning step (for each OS separately) to make sure its a valid path.

Specifically, here C:\Temp\Title...\Image1.jpg is not permitted, yet gallery-dl creates these folders with trailing dots and they can only be removed by the cmd prompt.

Please let me know if a filter is already built in or can be augmented to handle this exception. Thanks! Working great otherwise!

[mikf]

Trailing dots are now getting removed from directory names (9159cb8), but I've taken another look at https://docs.microsoft.com/en-us/windows/win32/fileio/naming-a-file and realized that their is still quite a lot to be done to cover all cases.

There are two "built in" options that kind of deal with stuff like this, but they wouldn't really have helped here: path-restrict and path-remove. They apply to both directory and file names, and there is no good way to use them to remove characters from the end of a string.

[chrsmlls333]

Thanks for your prompt work on this!

Found a library here: https://pypi.org/project/pathvalidate/
Im much more familiar with node's built-in path join function

Your method of building by path segment seems sound to me, perhaps replace those path-restrict and path-remove with a unified validation option, and operate a function across each segment as its built. I would also add a catch for if the input is all unpermitted characters.

My main question I guess is, is there a reason why this should be an option? Should generated paths not be both unix- and windows-safe by default?