Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aryion] get post ID via gallery-item (Fixes #981) #982

Closed
wants to merge 1 commit into from
Closed

[aryion] get post ID via gallery-item (Fixes #981) #982

wants to merge 1 commit into from

Conversation

kattjevfel
Copy link
Contributor

This makes gallery-dl able to get aryion posts lacking a thumbnail, such as many text documents.

..rather than thumb, since this obviously won't
work for posts without thumbnails.
@mikf
Copy link
Owner

mikf commented Sep 6, 2020

Thank you, but this doesn't work when fetching IDs from https://aryion.com/g4/latest.php?id=…, i.e. with recursive disabled. I guess we could use the old method for "recursive": false and yours for "recursive": true.

@kattjevfel
Copy link
Contributor Author

kattjevfel commented Sep 6, 2020

I wasn't aware of that even being an option. It there a reason someone would turn off recursive? I might be missing something here but I don't see any reason in using https://aryion.com/g4/latest.php?id=.

On my end (with nothing but filename and login details set), everything seems to be working just fine. Both individual posts and entire galleries.

EDIT: If any reason happen to be that I did it that way in my bash script, it's simply because I was lazy and didn't wanna implement directories. But your implementation is superior in every single way.

@mikf mikf closed this in bc48514 Sep 6, 2020
@mikf
Copy link
Owner

mikf commented Sep 6, 2020

The initial implementation was using /g4/latest.php?id=, because both your script and the one from #673 used it, but then #832 came along and a recursive option was added to ensure backwards compatibility.

bc48514 should work for both strategies. Again, thanks for your fix.

@kattjevfel kattjevfel deleted the aryionthumbs branch September 17, 2020 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants