Patches for Array not compliant to JSON #1

Open
jpfiset opened this Issue Sep 29, 2011 · 2 comments

1 participant

@jpfiset

When a patch is generated for an array, the index of the changed elements is used as the key for the definition of the change within the patch. This lead to a patch that contains numbers as keys, which is not compliant with JSON.

Therefore, where indices are concerned, they should probably be escaped as strings. Adding an underscore in front of indices might be a valid way to go.

@jpfiset

I added code to fix this issue, but it ended up in the pull request for issue #2.

@jpfiset jpfiset closed this Sep 29, 2011
@jpfiset jpfiset reopened this Sep 29, 2011
@jpfiset

I am obviously not tuned the the GitHub UI. Ended up closing and reopening issue. Sorry for the spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment