feat(core): add Reference.set() method

Issue: #264
mikro-orm · Dec 10, 2019 · 08cbead · 08cbead
1 parent ab7b9cd
commit 08cbead
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 4 deletions.
diff --git a/docs/docs/entity-references.md b/docs/docs/entity-references.md
@@ -111,6 +111,12 @@ book.author = Reference.create(repo.getReference(2));
 await orm.em.flush();
 ```
 
+If the reference already exist, you can also re-assign to it via `set()` method:
+
+```typescript
+book.author.set(new Author(...));
+```
+
 ## What is IdentifiedReference?
 
 `IdentifiedReference` is an intersection type that adds primary key property to the `Reference` 

diff --git a/lib/entity/Reference.ts b/lib/entity/Reference.ts
@@ -6,19 +6,20 @@ export type IdentifiedReference<T extends AnyEntity<T>, PK extends keyof T = 'id
 
 export class Reference<T extends AnyEntity<T>> {
 
-  constructor(private readonly entity: T) {
+  constructor(private entity: T) {
+    this.set(entity);
     const wrapped = wrap(this.entity);
 
     Object.defineProperty(this, wrapped.__meta.primaryKey, {
       get() {
-        return wrapped.__primaryKey;
+        return wrap(this.entity).__primaryKey;
       },
     });
 
     if (wrapped.__meta.serializedPrimaryKey && wrapped.__meta.primaryKey !== wrapped.__meta.serializedPrimaryKey) {
       Object.defineProperty(this, wrapped.__meta.serializedPrimaryKey, {
         get() {
-          return wrapped.__serializedPrimaryKey;
+          return wrap(this.entity).__serializedPrimaryKey;
         },
       });
     }
@@ -45,6 +46,14 @@ export class Reference<T extends AnyEntity<T>> {
     return this.entity[prop];
   }
 
+  set(entity: T | IdentifiedReference<T>): void {
+    if (entity instanceof Reference) {
+      entity = entity.unwrap();
+    }
+
+    this.entity = entity;
+  }
+
   unwrap(): T {
     return wrap(this.entity);
   }

diff --git a/tests/EntityManager.mongo.test.ts b/tests/EntityManager.mongo.test.ts
@@ -1579,7 +1579,8 @@ describe('EntityManagerMongo', () => {
 
   test('reference wrapper', async () => {
     const author = new Author('God', 'hello@heaven.god');
-    await orm.em.persistAndFlush(author);
+    const author2 = new Author('God 2', 'hello2@heaven.god');
+    await orm.em.persistAndFlush([author, author2]);
     orm.em.clear();
 
     const ref = orm.em.getReference<Author, 'id' | '_id'>(Author, author.id, true);
@@ -1596,6 +1597,11 @@ describe('EntityManagerMongo', () => {
     const ref3 = Reference.create(ref2);
     expect(ref2).toBe(ref3);
 
+    expect(ref3.unwrap()).toBe(author);
+    ref3.set(author2);
+    expect(ref3.unwrap()).toBe(author2);
+    expect(ref3.id).toBe(author2.id);
+
     const ent = await ref.load();
     expect(ent).toBeInstanceOf(Author);
     expect(wrap(ent).isInitialized()).toBe(true);