New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library-level citation notice and warnings #305

Merged
merged 1 commit into from Dec 16, 2017

Conversation

Projects
None yet
2 participants
@dbolotin
Member

dbolotin commented Dec 12, 2017

This fixes #285

Requires repseqio/repseqio#36 to be merged (+ submodule updated accordingly)

@dbolotin dbolotin requested a review from PoslavskySV Dec 12, 2017

// Printing citation notice, if specified for the library
if (!library.getCitations().isEmpty()) {
System.out.println("Please cite:");

This comment has been minimized.

@PoslavskySV

PoslavskySV Dec 15, 2017

Member

"Please cite:" or some other text? add option ?

@PoslavskySV

PoslavskySV Dec 15, 2017

Member

"Please cite:" or some other text? add option ?

This comment has been minimized.

@dbolotin

dbolotin Dec 16, 2017

Member

Like specify exact message in library meta field? I think fixed message is ok.

@dbolotin

dbolotin Dec 16, 2017

Member

Like specify exact message in library meta field? I think fixed message is ok.

This comment has been minimized.

@PoslavskySV

PoslavskySV Dec 16, 2017

Member

This implies that "citation" in library is given in exactly in citation format (should be documented), since someone may add "Please cite PaperXXX" text already in the library citation message.

@PoslavskySV

PoslavskySV Dec 16, 2017

Member

This implies that "citation" in library is given in exactly in citation format (should be documented), since someone may add "Please cite PaperXXX" text already in the library citation message.

This comment has been minimized.

@dbolotin

dbolotin Dec 16, 2017

Member

👍

@dbolotin

This comment has been minimized.

@dbolotin
@dbolotin
}
// Printing citation notice, if specified for the library
if (!library.getCitations().isEmpty()) {

This comment has been minimized.

@PoslavskySV

PoslavskySV Dec 15, 2017

Member

Flag to suppress citation required!

@PoslavskySV

PoslavskySV Dec 15, 2017

Member

Flag to suppress citation required!

This comment has been minimized.

@dbolotin

dbolotin Dec 16, 2017

Member

Connected to #224 and letter we received a week ago about "-q" (quiet) option.

@dbolotin

dbolotin Dec 16, 2017

Member

Connected to #224 and letter we received a week ago about "-q" (quiet) option.

This comment has been minimized.

@dbolotin

dbolotin Dec 16, 2017

Member

Created #307

@dbolotin
@dbolotin

This comment has been minimized.

Show comment
Hide comment
@dbolotin
Member

dbolotin commented Dec 16, 2017

@dbolotin dbolotin merged commit c40e059 into develop Dec 16, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@dbolotin dbolotin deleted the citation_notice branch Dec 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment