New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fullseq fixes and updates #339

Merged
merged 3 commits into from Feb 7, 2018

Conversation

Projects
None yet
2 participants
@dbolotin
Member

dbolotin commented Feb 7, 2018

No description provided.

dbolotin added some commits Feb 7, 2018

Number of threads in assembleContigs reduced to 1, added exception fo…
…r higher value.

Minor corrections.
Seed script for tests on big datasets.
Test data download integrated into travis pipeline.
@PoslavskySV

This comment has been minimized.

variable is not used?

This comment has been minimized.

Member

dbolotin replied Feb 7, 2018

👍

fix

@dbolotin dbolotin requested a review from PoslavskySV Feb 7, 2018

}
assert report.getFinalCloneCount() == totalClonesCount;

This comment has been minimized.

@PoslavskySV

PoslavskySV Feb 7, 2018

Member

? should use equality with error, e.g. Math.abs(a - b) < 1e-6 ?

This comment has been minimized.

@dbolotin

dbolotin Feb 7, 2018

Member

This is number of clones (int)

This comment has been minimized.

@PoslavskySV

PoslavskySV Feb 7, 2018

Member

😳👌

@dbolotin dbolotin merged commit d265cec into develop Feb 7, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@dbolotin dbolotin deleted the fullseq_fixes_and_updates branch Feb 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment