New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing implicit annotations. #123

Open
milessabin opened this Issue Jun 25, 2014 · 5 comments

Comments

Projects
None yet
3 participants
@milessabin
Owner

milessabin commented Jun 25, 2014

There are very many implicit arguments in shapeless without @implicitNotFound annotations. Adding them would make compiler errors more readable.

@ceedubs

This comment has been minimized.

Show comment
Hide comment
@ceedubs

ceedubs Jul 12, 2014

Collaborator

@milessabin does this issue refer to explicitly annotating the return types of implicit vals and defs or to adding @implicitNotFound annotations to type classes?

Collaborator

ceedubs commented Jul 12, 2014

@milessabin does this issue refer to explicitly annotating the return types of implicit vals and defs or to adding @implicitNotFound annotations to type classes?

@milessabin

This comment has been minimized.

Show comment
Hide comment
@milessabin

milessabin Jul 16, 2014

Owner

@ceedubs description updated.

Owner

milessabin commented Jul 16, 2014

@ceedubs description updated.

@milessabin

This comment has been minimized.

Show comment
Hide comment
@milessabin

milessabin Oct 3, 2014

Owner

Partially addressed in #239 ... lots more to do.

Owner

milessabin commented Oct 3, 2014

Partially addressed in #239 ... lots more to do.

@joroKr21

This comment has been minimized.

Show comment
Hide comment
@joroKr21

joroKr21 May 9, 2017

Contributor

What would be a good template for the error messages? I'm thinking something like this:

Implicit not found: TypeClass[A, B, C].
Could not prove / compute / infer whatever type lever operation with A, B and C.

Then the question is whether to keep it short (a 2-lliner) or try to elaborate possible causes / solutions e.g: "Try to use the Aux pattern", "Make sure your Poly has the right arity", etc.

Contributor

joroKr21 commented May 9, 2017

What would be a good template for the error messages? I'm thinking something like this:

Implicit not found: TypeClass[A, B, C].
Could not prove / compute / infer whatever type lever operation with A, B and C.

Then the question is whether to keep it short (a 2-lliner) or try to elaborate possible causes / solutions e.g: "Try to use the Aux pattern", "Make sure your Poly has the right arity", etc.

@milessabin

This comment has been minimized.

Show comment
Hide comment
@milessabin

milessabin May 10, 2017

Owner

I think the messages should be specific to the particular type class in question ... I'm not sure that replacing the existing default message with a similarly non-specific template would be all that much of an improvement.

Owner

milessabin commented May 10, 2017

I think the messages should be specific to the particular type class in question ... I'm not sure that replacing the existing default message with a similarly non-specific template would be all that much of an improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment