code review of CFRelease usage, minor changes

miliuco · Jan 5, 2010 · 756b37d · 756b37d
1 parent 36b7d43
commit 756b37d
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/SUDiskImageUnarchiver.m b/SUDiskImageUnarchiver.m
@@ -33,9 +33,12 @@ - (void)extractDMG
 		if (uuid)
 		{
 			CFStringRef uuidString = CFUUIDCreateString(NULL, uuid);
+			if (uuidString)
+			{
+				mountPoint = [@"/Volumes" stringByAppendingPathComponent:(NSString*)uuidString];
+				CFRelease(uuidString);
+			}
 			CFRelease(uuid);
-			mountPoint = [@"/Volumes" stringByAppendingPathComponent:(NSString*)uuidString];
-			CFRelease(uuidString);
 		}
 	}
 	while (noErr == FSPathMakeRefWithOptions((UInt8 *)[mountPoint fileSystemRepresentation], kFSPathMakeRefDoNotFollowLeafSymlink, &tmpRef, NULL));

diff --git a/SUHost.m b/SUHost.m
@@ -108,8 +108,8 @@ - (BOOL)isBackgroundApplication
 {
 	ProcessSerialNumber PSN;
 	GetCurrentProcess(&PSN);
-	NSDictionary * processInfo = (NSDictionary *)ProcessInformationCopyDictionary(&PSN, kProcessDictionaryIncludeAllInformationMask);
-	BOOL isElement = [[processInfo objectForKey:@"LSUIElement"] boolValue];
+	CFDictionaryRef processInfo = ProcessInformationCopyDictionary(&PSN, kProcessDictionaryIncludeAllInformationMask);
+	BOOL isElement = [[(NSDictionary *)processInfo objectForKey:@"LSUIElement"] boolValue];
 	if (processInfo)
 		CFRelease(processInfo);
 	return isElement;