Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipe for emms-player-simple-mpv #2682

Merged
merged 1 commit into from Apr 17, 2015

Conversation

momomo5717
Copy link
Contributor

https://github.com/momomo5717/emms-player-simple-mpv

This is an extension of emms-palyer-simple.el for mpv JSON IPC.
I think it is useful for defining a emms player for specific protocols or input forms such as ffplay form
(for example emms-player-mpv-jp-radios).

I'm not good at English. So there might exist unclear variable name or sentences.
I apologize in advance if there are any mistake.

Thank you for your help.

@purcell
Copy link
Member

purcell commented Apr 17, 2015

We already have emms-player-mpv -- is this different?

@momomo5717
Copy link
Contributor Author

Thank you for the quick response.

Yes, it is.

emms-player-mpv is one of the emms players and easy to use.

emms-player-simple-mpv helps to define different kinds of emms players of mpv like emms-player-simple.el, because mpv needs specific input format or parameters to play some streaming URLs or protocols, and it supports JSON IPC to extend control functions.

@purcell
Copy link
Member

purcell commented Apr 17, 2015

Okay, great.

Which package provides later-do? I think perhaps there's a missing dependency.

(Also: sent a quick fix in momomo5717/emms-player-simple-mpv#1)

@momomo5717
Copy link
Contributor Author

Thank you for fixing it! I've merged.

EMMS includes later-do.el.
Should I write the dependency?

purcell added a commit that referenced this pull request Apr 17, 2015
…e-mpv

Add recipe for emms-player-simple-mpv
@purcell purcell merged commit f4eaa86 into melpa:master Apr 17, 2015
@purcell
Copy link
Member

purcell commented Apr 17, 2015

EMMS includes later-do.el.
Should I write the dependency?

Nope, that's fine -- I just needed to make sure that one of the declared dependencies included that file.

@momomo5717
Copy link
Contributor Author

I see.

Thank you very much for your kindness.

@momomo5717 momomo5717 deleted the add_recipe_emms-player-simple-mpv branch April 17, 2015 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants