compiled emacs with srgb, separator colors are wrong #54

Open
LeoLionel opened this Issue Feb 25, 2014 · 19 comments

Projects

None yet
@LeoLionel

Hallo!

I compiled emacs24 on my mac with homebrew and the srgb option
(https://github.com/Homebrew/homebrew/blob/master/Library/Formula/emacs.rb)

Now using powerline the colors of the separators don't match the color-theme anymore.
Is there away to get them right?

Cheers!

powerline-srgb

@deftsp
deftsp commented Feb 25, 2014

I have the same problem. on OS X 10.9, emacs-bzr-version: 116475.

@milkypostman
Owner

I remember this being an issue but in not sure what the fix is.
On Feb 25, 2014 5:34 AM, "Shihpin Tseng" notifications@github.com wrote:

I have the same problem. on OS X 10.9, emacs-bzr-version: 116475.


Reply to this email directly or view it on GitHubhttps://github.com/milkypostman/powerline/issues/54#issuecomment-36007231
.

@klobucar

Same problem +1 to a solution

@rymndhng

same still have problem!

@milkypostman
Owner

Yeah, i don't have a solution to this problem. It's the fact that whatever
code is being used to generate the pixmaps is not using the new srgb stuff.
maybe there is some small code change that needs to happen elsewhere?

On Tue, Jul 29, 2014 at 9:04 AM, Ray H notifications@github.com wrote:

same still have problem!


Reply to this email directly or view it on GitHub
#54 (comment)
.

@gizmomogwai

I have the same problem with emac 24.4.50.1

@jacobj
jacobj commented Sep 15, 2014

+1, using 24.4 on OS X. I didn't explicitly compile emacs with srgb but I think it's default in 24.4?

@jackrusher

+1, 24.4 on OS X.

@milkypostman
Owner

Known issue. Nothing we can do really unless we detect it, we currently
cannot, and then manually adjust the colors
On Mon, Oct 27, 2014 at 05:22 Jack Rusher notifications@github.com wrote:

+1, 24.4 on OS X.


Reply to this email directly or view it on GitHub
#54 (comment)
.

@jupl
jupl commented Dec 1, 2014

You can turn off sRGB to make the colors look right.

(setq ns-use-srgb-colorspace nil)

Source

@qiushihe

Thanks @jupl that worked for me.

@chiangqiqi

@jupl This works for me too, but can u basically explain why?

@sellout
Contributor
sellout commented Apr 28, 2015

@chiangqiqi I think @jupl’s change basically makes the colors “wrong” for the rest of Emacs as well, so they match the colors used by the pixmaps.

There are many colorspaces – sRGB is one of them. Disabling the use of sRGB switches to an uncorrected colorspace, which is what the image generation program must be using as well. So, turning off sRGB will make all your Emacs colors slightly off, but at least it will match.

I had the opposite of this problem with sellout/emacs-color-theme-solarized, back when Cocoa Emacs didn’t support sRGB at all, and users would complain that the theme colors were wrong (but with an uncorrected space, the right colors had slightly different values on different machines, so fixing them for one user could make them worse for another user).

I don’t have a solution here, unfortunately. But I’ll look into it.

@sellout sellout referenced this issue in sellout/emacs-color-theme-solarized Apr 28, 2015
Closed

Add support for Powerline #115

@sellout
Contributor
sellout commented Apr 28, 2015

Oh, another workaround is to use UTF-8 separators, then you don’t have the issue with XPM colors. The best separators I’ve found are ►/◄ (#x25ba / #x25c4) – please let me know if you find others that look better!

@jasonm23
Collaborator

The graphics are generated as xpm pixel maps so there's no color space encoding, that's why they don't look right in sRGB.

@qiushihe

For anyone interested, this is the workaround I'm currently using to get the colours to look good under sRGB: http://irrationalrose.com/2015/05/29/workaround-for-srgb-colour-issue-for-powerline-on-os-x.html

@darker0n darker0n referenced this issue in syl20bnr/spacemacs Aug 13, 2015
Closed

Graphical glitches #2631

@darker0n

@jupl 👍

@kissge kissge added a commit to kissge/.emacs.d that referenced this issue Nov 10, 2015
@kissge kissge Fix the problem powerline's separators looked ugly 8b247dc
@geraldus

Oh, another workaround is to use UTF-8 separators, then you don’t have the issue with XPM colors. The best separators I’ve found are ►/◄ (#x25ba / #x25c4) – please let me know if you find others that look better!

This is why I disabled separators completely, pixmap separators have wrong background colour and looks ugly on Retina display, and UTF-8 separators are missed in most fonts (I change frame font quite frequently because due to my nature things quickly bored me). Oh, by the way recently I have found that it's totally easy and OK to customize mode-line face setting height and font family different to default face.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment