Fix possible stack corruption with XM instrument headers claiming a s…

…ize of less than 4 Closes #275
milkytracker · Jun 26, 2022 · 3a5474f · 3a5474f
1 parent 66c31bf
commit 3a5474f
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/milkyplay/LoaderXM.cpp b/src/milkyplay/LoaderXM.cpp
@@ -478,7 +478,7 @@ mp_sint32 LoaderXM::load(XMFileBase& f, XModule* module)
 
 			f.readDwords(&instr[y].size,1);
 
-			if (instr[y].size < 29)
+			if (instr[y].size >= 4 && instr[y].size < 29)
 			{
 				mp_ubyte buffer[29];
 				memset(buffer, 0, sizeof(buffer));