New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS - Hero buttons broken #38

Closed
williampansky opened this Issue Mar 21, 2017 · 3 comments

Comments

Projects
None yet
1 participant
@williampansky
Contributor

williampansky commented Mar 21, 2017

Get table & learn more buttons inactive; tested on iPhone 5.

Oddly enough, the buttons work in Xcode Simulator.

@williampansky williampansky added the bug label Mar 21, 2017

@williampansky williampansky added this to the Deployment milestone Mar 21, 2017

@williampansky

This comment has been minimized.

Contributor

williampansky commented Mar 22, 2017

6s works fine

@williampansky

This comment has been minimized.

Contributor

williampansky commented Mar 22, 2017

Okay; coworker's have iPhone 6SE and iPhone 5 in the office - both running on 9.3.X- version of iOS; seems that is the culprit here.

@williampansky

This comment has been minimized.

Contributor

williampansky commented Mar 22, 2017

Downloaded iOS 9.3 for Xcode Simulator and found the issue to be the syntax let self = this; in StickyNav.js line 8. Apparently, let produces the error: SyntaxError: Unexpected use of reserved word 'let' in strict mode due to lack of support for let.

As a quick-fix (deadline approaching fast), I've implemented this bit of info to detect if the version of iOS = 9.x.x and run the following conditionals if so:

// run if iOS ver = 9.x.x
if(/(iPhone|iPad|iPod)\sOS\s9/.test(navigator.userAgent)) {
    var btn = $("#heroButtons");
    var bar = $(".et-hero-tabs-container");
    btn.remove();
    bar.css("position", "fixed");
    bar.css("top", "0");
    bar.css("height", "50px");
    bar.css("border-bottom", "1px solid #595959");
};

maa-wpansky pushed a commit that referenced this issue Mar 22, 2017

maa-wpansky maa-wpansky
Pre-Deployment Fixes
Issues closed: #38, #39, #24, #25, #23, #28, #9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment