Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Some basic cleanup #1

Merged
merged 3 commits into from May 12, 2012

Conversation

Projects
None yet
2 participants
Contributor

bendavieshe3 commented May 12, 2012

Hi, Thanks for taking the time to create this plugin!

I am new to Grails so please check the changes.

Basically I have:

  1. cleaned up some of the println statements (it looks like some debug statements were still present)
  2. removed some unnecessary datasource declarations (noticed when my Grails install started pulling down H2 dependencies before running)
  3. moved the ant task dependency to a compile-time instead of runtime dependency

If you are amenable there are a few more usability/robustness changes I could make, time pending.

Thanks again.

Collaborator

beckje01 commented May 12, 2012

Thanks for the work all the changes look good.

@beckje01 beckje01 added a commit that referenced this pull request May 12, 2012

@beckje01 beckje01 Merge pull request #1 from bendavieshe3/master
Some basic cleanup
93e6101

@beckje01 beckje01 merged commit 93e6101 into millerjam:master May 12, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment