should presets be plugins? #189

Closed
millermedeiros opened this Issue Jul 7, 2014 · 3 comments

Comments

Projects
None yet
3 participants
@millermedeiros
Owner

millermedeiros commented Jul 7, 2014

I just processed jQuery 2.1.1 on esformatter@0.4.0 with the jquery preset and there are some changes that we do to the code that are different from what a developer would do (edge cases based on the context), but I think they are unique to jquery style guide and really can't be represented easily with just integers/strings/booleans (and would be very easy to implement as a plugin)..

I also think that maintaining a large set of presets inside esformatter codebase will be PITA to maintain.. more test files and each change to the style guide will need a version bump on esformatter itself.

plugins can override the settings on the setOptions hook (if they are just presets) and can be released separately from esformatter and npm is a great way to install dependencies.

/cc @jzaefferer

@jzaefferer

This comment has been minimized.

Show comment Hide comment
@jzaefferer

jzaefferer Jul 7, 2014

Collaborator

That sounds sane. I won't be able to work on this in the next few months, but I'm definitely interested. My main concern right now would be unit testing. The infrastructure here works pretty well and I wouldn't want to replicate all that when creating a preset plugin.

Collaborator

jzaefferer commented Jul 7, 2014

That sounds sane. I won't be able to work on this in the next few months, but I'm definitely interested. My main concern right now would be unit testing. The infrastructure here works pretty well and I wouldn't want to replicate all that when creating a preset plugin.

@jeddy3 jeddy3 referenced this issue in stylelint/stylelint Jan 2, 2015

Closed

Rules #1

88 of 105 tasks complete
@bcomnes

This comment has been minimized.

Show comment Hide comment
@bcomnes

bcomnes Feb 23, 2015

I think this would be a good idea, as it would promote the use of plugins to provide a preset. https://github.com/maxogden/standard-format would make a good preset, but it would be better if it could be kept in its own repo by people who are interested in maintaining it.

bcomnes commented Feb 23, 2015

I think this would be a good idea, as it would promote the use of plugins to provide a preset. https://github.com/maxogden/standard-format would make a good preset, but it would be better if it could be kept in its own repo by people who are interested in maintaining it.

@millermedeiros

This comment has been minimized.

Show comment Hide comment
@millermedeiros

millermedeiros Mar 3, 2015

Owner

presets should really become plugins, closing this in favor of #249

Owner

millermedeiros commented Mar 3, 2015

presets should really become plugins, closing this in favor of #249

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment