Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[META] support ES6 features! #192

Closed
millermedeiros opened this issue Jul 8, 2014 · 16 comments
Closed

[META] support ES6 features! #192

millermedeiros opened this issue Jul 8, 2014 · 16 comments
Labels
feature

Comments

@millermedeiros
Copy link
Owner

as long as it is supported by esprima it should be fairly easy to add it. (eg. ArrowFunctionExpression)
@millermedeiros
Copy link
Owner Author

esprima doc about es6 features: http://esprima.org/doc/es6.html - only partial support for now.

@Volox
Copy link

Volox commented Jul 9, 2014

+1 it will be great to have support for generators so it can be used right now with koajs.

@millermedeiros millermedeiros mentioned this issue Jul 14, 2014
Closed
@millermedeiros
Copy link
Owner Author

I started a test branch of rocambole using acorn instead of esprima, but it looks like both projects uses different range info, so it should take a little bit longer to make it work properly with esformatter.

@millermedeiros millermedeiros mentioned this issue Sep 6, 2014
Closed
@lukescott
Copy link

Esprima 2.0 was released 20 days ago, which has (partial) ES6 support. 6 days ago class support was added to the master branch.

@millermedeiros
Copy link
Owner Author

@lukescott just tested esprima@2.0 and it only introduced a single regression to the esformatter tests.. and it is definitely an edge case (probably related to EmptyStatement not existing anymore on the AST)

millermedeiros added a commit that referenced this issue Feb 26, 2015
@millermedeiros
update rocambole to v0.5 and change the BinaryExpression test to matc…
b9d91a6 
…h esprima@2.0 behavior (no EmptyStatement between ExpressionStatements). see #192
@millermedeiros
Copy link
Owner Author

I just published rocambole@0.5 which uses esprima@2.0, so now we can start adding tests and support for ES6 features \o/

@ruyadorno
Copy link
Collaborator

🎉 🎉 🎉

@eduardolundgren
Copy link
Contributor

Thank you @millermedeiros :)

@RaitoBezarius
Copy link
Contributor

What about replacing esprima by babel (which supports more ES6 features afaik) ?
Is that possible? I can help, if it is not too complicated.

@bobbyrenwick
Copy link

👍

@feross feross mentioned this issue Mar 23, 2015
Closed
@millermedeiros
Copy link
Owner Author

@RaitoBezarius babel uses acorn internally and we would have the same issues with the token ranges (would require changes to the way we detect the start/end of nodes). right now we are trapped with esprima v2.

it would be helpful if we had new bugs for each ES6 feature that we don't format properly yet, with input and expected outuput. I don't even know which features are supported by esprima at the moment...

This was referenced Mar 24, 2015
Closed
Closed
Closed
Closed
millermedeiros added a commit that referenced this issue Mar 31, 2015
@millermedeiros
use espree to parse the programs to enable JSX support and more ES6 f…
6ebac85 
…eatures. also allows the user to replace the parser if needed.

see #192
see #242
This was referenced Mar 31, 2015
Closed
Closed
Closed
@0x80 0x80 mentioned this issue Apr 18, 2015
Closed
@millermedeiros millermedeiros mentioned this issue Apr 18, 2015
Closed
@millermedeiros millermedeiros changed the title support ES6 features! [META] support ES6 features! Apr 28, 2015
@seeekr seeekr mentioned this issue Jun 13, 2015
Closed
@leeola leeola mentioned this issue Jun 17, 2015
Closed
@millermedeiros
Copy link
Owner Author

I believe we covered all the ES6 features on v0.7; if anything else is missing/wrong please open as a separate bugs. Thanks.

@eduardolundgren
Copy link
Contributor

Thank you @millermedeiros :)

@kewah
Copy link
Contributor

kewah commented Jul 10, 2015

good work 👍

@tommmyy
Copy link

tommmyy commented Aug 27, 2015

Is there possibility that esformatter does not support static class properties (it is included by Babel in stage 0)?

@millermedeiros
Copy link
Owner Author

@tommmyy for now we can only support features that are implemented by espree. which doesn't support experimental features so far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
9 participants
@eduardolundgren @millermedeiros @kewah @ruyadorno @RaitoBezarius @lukescott @bobbyrenwick @Volox @tommmyy